(FACT-1281) Allow host configs to be generated at runtime #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I try to run this on top of stable, I get |
| if platforms | ||
| cli = BeakerHostGenerator::CLI.new([platforms, '--disable-default-role']) | ||
| ENV['CONFIG'] = "tmp/#{platforms}-#{SecureRandom.uuid}.yaml" | ||
| File.open(config, 'w') do |fh| |
There was a problem hiding this comment.
Where does this config variable come from? Well that's not the problem.
This Rakefile assumes the presence of acceptance/tmp. Adding Dir.mkdir('tmp') seems to work as an option.
There was a problem hiding this comment.
Down below there's
def config
ENV['CONFIG']
end
|
I'm going to close this PR while we work on getting ci-job-configs and hiera figured out. |
joshcooper
force-pushed
the
ticket/stable/FACT-1281-use-beaker-hg
branch
from
ed85c88
to
e9b279e
Compare
|
Verified using: |
|
Did you start with a |
|
Ah that must be it. It's in the .gitignore list so didn't realize it was generated during the build. |
This commit adds a dependency on beaker-hostgenerator in the
acceptance Gemfile, which may be overridden using the
`BEAKER_HOSTGENERATOR_VERSION` environment variable.
The acceptance Rakefile will continue to use the `CONFIG` environment
variable, which must point to an existing host config file.
If `TEST_TARGET` is specified, it will override `CONFIG`, and the Rakefile
will use beaker-hostgenerator to dynamically generate a host config. The
host config is generated in the `acceptance/tmp` directory, as
opposed to `/tmp` so that it doesn't conflict with concurrent acceptance
tests running on the same CI coordinator. It also appends SecureRandom
to the hostfile, because it seems like a good idea. The resulting host
config is copied to the `log/latest/config.yml`.
For example, to run against a tagged build:
$ bundle exec rake ci:test:aio TEST_TARGET=redhat7-64a SHA=1.3.2
To run against a non-tagged commit:
$ bundle exec rake ci:test:aio TEST_TARGET=redhat7-64a \
SHA=<full sha> SUITE_VERSION=<git describe>
This commit doesn't remove the static host configs as CI jobs need
to be updated first.
joshcooper
force-pushed
the
ticket/stable/FACT-1281-use-beaker-hg
branch
from
e9b279e
to
f1608d9
Compare
|
👍 looks good to me |
|
Hiera failed, hold off until that's fixed. |
|
Superceded by #1244, which adds the one-line, temporary workaround discussed in HipChat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a dependency on beaker-hostgenerator in the acceptance
Gemfile, which may be overridden using the
BEAKER_HOSTGENERATOR_VERSIONenvironment variable.The acceptance Rakefile will continue to use the
CONFIGenvironmentvariable, which points to an existing host config file.
If
PLATFORMSis specified, it will overrideCONFIG, and the Rakefilewill use beaker-hostgenerator to dynamically generate a host config. The
host config is generated in the
facter/acceptance/tmpdirectory, asopposed to
/tmpso that it doesn't conflict with concurrent acceptancetests running on the same CI coordinator. It also appends SecureRandom
to the hostfile, because it seems like a good idea. The resulting host
config is copied to the
log/latest/config.yml.For example, to run against a tagged build:
To run against a non-tagged commit:
This commit doesn't remove the static host configs as CI jobs need to be
updated first.