(FACT-1321) Install facter batch files on windows #1263

melissa · 2016-01-26T15:53:44Z

As we switch to building puppet-agent for windows with vanagon, we need
access to resources that currently live in puppet_for_the_win. Though
these resources depend on resources that are made available in
puppet-agent, it makes sense to store these in the project specific
repo.

This takes advantage of environment.bat in puppet-agent installed with puppetlabs/puppet-agent#512

melissa · 2016-01-26T17:46:49Z

ext/windows/run_facter_interactive.bat

+) else (
+  SET PATH=%~dp0;%PATH%
+)
+elevate.exe "%~dp0facter_interactive.bat"


facter.bat and facter_interactive.bat work fine, but I'm having trouble with run_facter_interactive.bat. It seems like the call to elevate.exe isn't right. Any thoughts?

cc/ @joshcooper @MikaelSmith

Also, puppetlabs/puppet-agent#515 will install elevate.exe and elevate.exe.config

It's just Cygwin.

This wasn't working in cygwin. Running from not-cygwin worked as expected

Do we know the path to elevate.exe relative to the directory where run_facter_interactive.bat is installed?

if it's installed as a part of puppet-agent, it should be in the same directory

shrug · 2016-01-27T21:49:29Z

👍

melissa · 2016-01-28T21:48:17Z

cc/ @MikaelSmith @kylog @joshcooper could one of you review this?

joshcooper · 2016-01-29T05:02:04Z

ext/windows/facter.bat

@@ -0,0 +1,8 @@
+@echo off
+SETLOCAL
+if exist "%~dp0environment.bat" (


When will environment.bat not exist?

See comments on puppetlabs/hiera#340

The interesting part about facter is that these files aren't installed by the system, they have to be purposefully copied over. I figured that since they're in the public facter repo, theoretically they should be able to be used on their own. So, if someone just installs this on their system without environment.bat, it should still work. The other batch scripts assume ruby is in the working directory, so I kept that assumption here if environment.bat doesn't exist.

MikaelSmith · 2016-02-02T01:09:52Z

These look like they need to be installed. We could make them part of the CMake install task on Windows, something like what we do for man pages at https://github.com/puppetlabs/facter/blob/master/CMakeLists.txt#L152.

melissa · 2016-02-02T02:16:25Z

@MikaelSmith yeah, that seems totally legit. I wasn't sure how to do that. Thanks for pointing me to that example!

melissa · 2016-02-03T17:31:45Z

It installs the files as expected on windows

C:\ProgramData\chocolatey\lib\cmake\content\cmake-3.2.2-win32-x86\bin\cmake.exe -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: C:/Program Files/Puppet Labs/puppet/share/man/man8/facter.8
-- Installing: C:/Program Files/Puppet Labs/puppet/bin/facter.bat
-- Installing: C:/Program Files/Puppet Labs/puppet/bin/facter_interactive.bat
-- Installing: C:/Program Files/Puppet Labs/puppet/bin/run_facter_interactive.bat
-- Installing: C:/Program Files/Puppet Labs/puppet/lib/libfacter.so.a
-- Installing: C:/Program Files/Puppet Labs/puppet/bin/libfacter.so
-- Installing: C:/Program Files/Puppet Labs/puppet/include/facter

and not on linux

/opt/pl-build-tools/bin/cmake -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: /opt/puppetlabs/puppet/share/man/man8/facter.8
-- Installing: /opt/puppetlabs/puppet/lib/libfacter.so.3.2.0
-- Installing: /opt/puppetlabs/puppet/lib/libfacter.so
-- Set runtime path of "/opt/puppetlabs/puppet/lib/libfacter.so.3.2.0" to "/opt/puppetlabs/puppet/lib"
-- Installing: /opt/puppetlabs/puppet/include/facter
-- Installing: /opt/puppetlabs/puppet/include/facter/facts
-- Installing: /opt/puppetlabs/puppet/include/facter/facts/external

cc/ @MikaelSmith

melissa · 2016-02-03T17:46:54Z

A change to puppet-agent that installed these new files before the cmake change was merged, and now needs to be reverted. puppetlabs/puppet-agent#526

MikaelSmith · 2016-02-03T18:02:19Z

Fine with this; I think it'd be cleaner to only have the batch files in "C:/Program Files/Puppet Labs/bin" and point to puppet/bin/facter.exe, but we can leave that for later. I'm not sure how you want to deal with that.

Making it happen could be done via configure_file to generate facter.bat from a template, and add an option to specify the install location for .bat files.

MikaelSmith · 2016-02-03T22:09:41Z

ext/windows/facter.bat

+if exist "%~dp0environment.bat" (
+  call "%~dp0environment.bat" %0 %*
+) else (
+  SET PATH=%~dp0;%PATH%


I think this needs to be quoted. When I try it out and %~dp0 is C:\Program Files\FACTER\bin I get the error

\FACTER\bin\ was unexpected at this time.

I was almost right, using SET PATH="%~dp0;%PATH%" creates an invalid PATH. It needs to be SET "PATH=%~dp0;%PATH%".

MikaelSmith · 2016-02-03T22:43:22Z

Facter.bat in a stand-alone install doesn't seem to find ruby.exe. Not sure why. Investigating.

As we switch to building puppet-agent for windows with vanagon, we need access to resources that currently live in puppet_for_the_win. Though these resources depend on resources that are made available in puppet-agent, it makes sense to store these in the project specific repo.

MikaelSmith · 2016-02-04T01:10:31Z

Looks good in stand-alone install and a puppet-agent build. 👍

…batch-files (FACT-1321) Install facter batch files on windows

melissa changed the title ~~(FACT-1321) Install facter batch files on windows~~ [WIP](FACT-1321) Install facter batch files on windows Jan 26, 2016

melissa mentioned this pull request Jan 26, 2016

(FACT-1321) Install windows batch scripts for facter puppetlabs/puppet-agent#511

Merged

melissa reviewed Jan 26, 2016
View reviewed changes

melissa force-pushed the ticket/master/FACT-1321-facter-batch-files branch from 7f728df to 8fe9caf Compare January 26, 2016 18:11

melissa changed the title ~~[WIP](FACT-1321) Install facter batch files on windows~~ (FACT-1321) Install facter batch files on windows Jan 27, 2016

melissa force-pushed the ticket/master/FACT-1321-facter-batch-files branch from 8fe9caf to 2b6202d Compare January 27, 2016 00:31

joshcooper reviewed Jan 29, 2016
View reviewed changes

melissa force-pushed the ticket/master/FACT-1321-facter-batch-files branch from 2b6202d to a579af2 Compare February 3, 2016 01:27

melissa mentioned this pull request Feb 3, 2016

Revert "(FACT-1321) Install windows batch scripts for facter" puppetlabs/puppet-agent#526

Merged

MikaelSmith reviewed Feb 3, 2016
View reviewed changes

melissa force-pushed the ticket/master/FACT-1321-facter-batch-files branch from a579af2 to b90fd08 Compare February 3, 2016 22:20

melissa force-pushed the ticket/master/FACT-1321-facter-batch-files branch from b90fd08 to a1b734c Compare February 3, 2016 23:38

MikaelSmith pushed a commit that referenced this pull request Feb 4, 2016

Merge pull request #1263 from melissa/ticket/master/FACT-1321-facter-…

1bd2ea3

…batch-files (FACT-1321) Install facter batch files on windows

MikaelSmith merged commit 1bd2ea3 into puppetlabs:master Feb 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(FACT-1321) Install facter batch files on windows #1263

(FACT-1321) Install facter batch files on windows #1263

melissa commented Jan 26, 2016

melissa Jan 26, 2016

melissa Jan 26, 2016

MikaelSmith Jan 27, 2016

melissa Jan 27, 2016

joshcooper Jan 29, 2016

melissa Feb 2, 2016

shrug commented Jan 27, 2016

melissa commented Jan 28, 2016

joshcooper Jan 29, 2016

melissa Jan 29, 2016

MikaelSmith commented Feb 2, 2016

melissa commented Feb 2, 2016

melissa commented Feb 3, 2016

melissa commented Feb 3, 2016

MikaelSmith commented Feb 3, 2016

MikaelSmith Feb 3, 2016

MikaelSmith Feb 3, 2016

MikaelSmith commented Feb 3, 2016

MikaelSmith commented Feb 4, 2016

(FACT-1321) Install facter batch files on windows #1263

(FACT-1321) Install facter batch files on windows #1263

Conversation

melissa commented Jan 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shrug commented Jan 27, 2016

melissa commented Jan 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikaelSmith commented Feb 2, 2016

melissa commented Feb 2, 2016

melissa commented Feb 3, 2016

melissa commented Feb 3, 2016

MikaelSmith commented Feb 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikaelSmith commented Feb 3, 2016

MikaelSmith commented Feb 4, 2016