(FACT-1282) parse routing table rules with a starting 'type' field #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should still be part of FACT-1282. |
The `ip` command is the worst, and thinks it's helpful to show the route type as an optional field before the route destination. This patch detects that case and allows us to keep parsing key/value pairs that appear in these rules.
branan
force-pushed
the
maint/stable/better_ip_parsing
branch
from
45046a3
to
5698e75
Compare
branan
changed the title
|
@MikaelSmith commit message updated. Not fixing my branch name since that means closing and re-opening the PR |
| // Iterate over key/value pairs and add the ones we care | ||
| // about to our routes entries | ||
| for (size_t i = 1; i < parts.size(); i += 2) { | ||
| for (size_t i = dst_idx+1; i < parts.size(); i += 2) { |
There was a problem hiding this comment.
This looks wrong; why start at 1 or 2? i.e. what format has x destination ...?
There was a problem hiding this comment.
[root@bqpdzd6yyu6gzck ~]# ip -6 route
unreachable ::/96 dev lo metric 1024 error -101
unreachable ::ffff:0.0.0.0/96 dev lo metric 1024 error -101
unreachable 2002:a00::/24 dev lo metric 1024 error -101
unreachable 2002:7f00::/24 dev lo metric 1024 error -101
unreachable 2002:a9fe::/32 dev lo metric 1024 error -101
unreachable 2002:ac10::/28 dev lo metric 1024 error -101
unreachable 2002:c0a8::/32 dev lo metric 1024 error -101
unreachable 2002:e000::/19 dev lo metric 1024 error -101
unreachable 3ffe:ffff::/32 dev lo metric 1024 error -101
fe80::/64 dev ens192 proto kernel metric 256
There was a problem hiding this comment.
It's entirely the way the ip command prints stuff. It's great for humans, but not awesome for parsing, unfortunately.
|
👍 |
MikaelSmith
pushed a commit
that referenced
this pull request
Mar 8, 2016
(FACT-1282) parse routing table rules with a starting 'type' field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ipcommand is the worst, and thinks it's helpful to show theroute type as an optional field before the route destination. This
patch detects that case and allows us to keep parsing key/value pairs
that appear in these rules.