(FACT-1847) Fix cloud fact implementation for Azure #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins please test this on redhat7-64a,ubuntu2004-64a,windows2012r2-64a |
GabrielNagy
force-pushed
the
FACT-1847/cloud-fact-3.x
branch
from
262888f
to
d598269
Compare
Since we now have an az_metadata fact, we can reimplement the cloud fact using this. The previous implementation was Linux-only and worked by searching for a specific string in the DHCP lease file, which does not work anymore (at least not on Ubuntu 20.04 Azure VMs). For the new implemetation, extract the cloud fact into its own resolver, as it indirectly depends on the virtual fact which is also part of the virtualization resolver. The new implementation should work regardless of OS, as it just checks for the existence of the az_metadata fact.
GabrielNagy
force-pushed
the
FACT-1847/cloud-fact-3.x
branch
from
d598269
to
dd5ef3b
Compare
ciprianbadescu
approved these changes
Mar 8, 2021
luchihoratiu
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now have an az_metadata fact, we can reimplement the cloud fact using this. The previous implementation was Linux-only and worked by searching for a specific string in the DHCP lease file, which does not work anymore (at least not on Ubuntu 20.04 Azure VMs).
For the new implemetation, extract the cloud fact into its own resolver, as it indirectly depends on the virtual fact which is also part of the virtualization resolver. The new implementation should work regardless of OS, as it just checks for the existence of the az_metadata fact.