cmake: explicit boost components discovery (required for boost 1.71)

[anthraxx]

Currently using boost 1.71 compiling the test executable results in
cmake errors for not using find_package for the required boost
components for proper discovery.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[GabrielNagy]

Hi @anthraxx,

Thanks for this! We noticed the issue after boost was bumped to 1.71 but didn't have time to get to it. I filed the following ticket for this: LTH-167.

Can you prepend the ticket name enclosed in brackets to the commit message? This helps us when writing changelogs on release. (e.g. (LTH-167) cmake: explicit boost components discovery)

Thank you

[puppetcla]

Waiting for CLA signature by @anthraxx

@anthraxx - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

[anthraxx]

Waiting for CLA signature by @anthraxx

@anthraxx - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

I don't think this single like cmake discovery really requires a CLA, it's hardly any meaningful contribution in terms of code but just a tiny toolchain adjustment.

PS: that trivial patch exemption link leads to a 404

[GabrielNagy]

That's fine, this is the correct link for trivial patches: https://puppet.com/community/trivial-patch-exemption-policy

[GabrielNagy]

👍