Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(packaging) Enable puppet-lint-plugins also on Windows #468 #469

Merged
merged 1 commit into from
May 16, 2022
Merged

(packaging) Enable puppet-lint-plugins also on Windows #468 #469

merged 1 commit into from
May 16, 2022

Conversation

ConradGroth
Copy link
Contributor

No description provided.

@ConradGroth ConradGroth requested review from a team as code owners April 5, 2022 16:46
@ConradGroth
Copy link
Contributor Author

I tested this change locally on Windows 10 with PDK 2.4.0 (using Ruby 2.5.9 and Puppet 6.26.0). It runs perfectly and now I get the same warnings as under Linux.

@ConradGroth
Copy link
Contributor Author

@bastelfreak WDYT? The original addition of the puppet-lint-plugins with the restriction to platform ruby was made by you two months ago.

@bastelfreak
Copy link
Contributor

I think I did that because I had no Windows to test it.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ConradGroth ConradGroth changed the title Enable puppet-lint-plugins also on Windows #468 (packaging) Enable puppet-lint-plugins also on Windows #468 May 4, 2022
david22swan
david22swan approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change look's good to me and seems to run fine.
Going to go ahead and merge.
Thanks for putting the work in :)

@david22swan david22swan merged commit 369d483 into puppetlabs:main May 16, 2022
@jordanbreen28 jordanbreen28 mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ConradGroth @bastelfreak @CLAassistant @david22swan @chelnak