(GH-543) - Fix merging of nested default facts #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
gh-543-fix_networking_facts_merge
branch
from
cb66796
to
4b0f252
Compare
bastelfreak
approved these changes
Jan 23, 2024
jordanbreen28
force-pushed
the
gh-543-fix_networking_facts_merge
branch
3 times, most recently
from
72ec29e
to
4ba6246
Compare
Ramesh7
previously approved these changes
Jan 29, 2024
jordanbreen28
force-pushed
the
gh-543-fix_networking_facts_merge
branch
from
4ba6246
to
120e542
Compare
jordanbreen28
force-pushed
the
gh-543-fix_networking_facts_merge
branch
from
120e542
to
a8c381f
Compare
|
The two PRs mentioned in the description have been merged. Is this ready for merge as well? |
|
@jordanbreen28 @LukasAud please have a look again. We released rspec-puppet-facts 3.0.0 today. |
jordanbreen28
force-pushed
the
gh-543-fix_networking_facts_merge
branch
from
a8c381f
to
815c74d
Compare
jordanbreen28
force-pushed
the
gh-543-fix_networking_facts_merge
branch
from
815c74d
to
e0864fb
Compare
david22swan
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues (if any)
Deep merges nested facts found in default_facts.yml
This is reliant on the progress, merge and release of this change: voxpupuli/rspec-puppet-facts#157 and voxpupuli/rspec-puppet-facts#160.
Once the above is released, config_defaults.yml will be updated if necessary to ensure we consume the appropriate release.