(PDK-987) Save CI resources / reduce developer feedback time #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we did syntax, lint, metadata lint in different containers. Depending on the CI system some were combined or they were all seperate. After this commit, we do all syntax, lint, metadata lint and some various checks from release_checks in one run. We leave rubocop separate for the time being.
Prior to this commit, rubocop ran in its own container seperate from all the other checks. After this commit, rubocop runs at the same time as the other lint, syntax, etc... checks.
npwalker
changed the title
DavidS
changed the title
DavidS
approved these changes
May 15, 2018
|
I like these changes. Before I merge though, I'd like @HelenCampbell or @pmcmaw to take a look and see if this will impact supported modules |
HelenCampbell
approved these changes
May 17, 2018
bmjen
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, we spent quite a bit of time spinning up containers and installing software instead of actually checking anything.
After this PR, we get quicker feedback and save resources on our various free CI providers by running more checks at the same time instead of in new containers.
Example of Travis before ( 311 seconds ):
Example of Travis after ( 66 seconds ):
Specifically Travis notes it only takes 2.89 seconds to run all checks:
Example Gitlab CI before:
Example Gitlab CI After:
