Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) implement `desc`/`docs` fallback #177

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@DavidS
Copy link
Contributor

commented May 30, 2019

This implements the changes specified in puppetlabs/puppet-specifications#141

The text and examples have been inconsistent with how desc vs docs
has been handled. This change fixes the text and examples to all show
and require desc, but accept docs in places where we showed it
previously.

@da-ar

da-ar approved these changes May 30, 2019

Copy link
Contributor

left a comment

looks good

@DavidS

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

The failing tests also fail on 1.6.x HEAD: https://travis-ci.org/puppetlabs/puppet-resource_api/builds/539161298

We can progress with this change and ticket up the puppet problem.

@DavidS DavidS force-pushed the DavidS:maint-desc-docs-fallback-1.6.x branch from 988491b to 844e937 Jun 12, 2019

@DavidS

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Including build fix from #184 .

@DavidS DavidS added the bug label Jun 12, 2019

(maint) implement `desc`/`docs` fallback
This implements the changes specified in puppetlabs/puppet-specifications#141

> The text and examples have been inconsistent with how `desc` vs `docs`
> has been handled. This change fixes the text and examples to all show
> and require `desc`, but accept `docs` in places where we showed it
> previously.

@DavidS DavidS force-pushed the DavidS:maint-desc-docs-fallback-1.6.x branch from 844e937 to 89c8808 Jun 12, 2019

@DavidS

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Rebasing for clean history after the tests preliminary passed.

@DavidS DavidS merged commit a1d9de2 into puppetlabs:1.6.x Jun 12, 2019

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 7bcd01a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DavidS DavidS deleted the DavidS:maint-desc-docs-fallback-1.6.x branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.