(PUP-8342) Update report serialization/deserialization, schema, and schema version to include transaction_completed

This update adds transaction_completed to report serialization/deserialization, and schema, and updates the schema version.

Author: kris-bosland

api/docs/http_report.md

@@ -55,9 +55,10 @@ example is formatted for readability)
      "job_id"=>null,
      "catalog_uuid"=>"827a74c8-cf98-44da-9ff7-18c5e4bee41e",
      "catalog_format"=>1,
-     "report_format"=>7,
+     "report_format"=>8,
      "puppet_version"=>"5.0.0",
      "status"=>"unchanged",
+     "transaction_completed"=>true,
      "noop"=>false,
      "noop_pending"=>false,
      "environment"=>"test_environment",

api/schemas/report.json

@@ -14,6 +14,7 @@
         "report_format",
         "puppet_version",
         "status",
+        "transaction_completed",
         "noop",
         "noop_pending",
         "environment"
@@ -126,7 +127,7 @@
         "report_format": {
             "description": "The report format version documented by this schema",
             "type":        "integer",
-            "enum":        ["7", 7]
+            "enum":        ["8", 8]
         },
 
         "puppet_version": {
@@ -143,6 +144,11 @@
             ]
         },
 
+        "transaction_completed": {
+                    "description": "Whether the transaction completed (e.g. didn't have an unrescued exception).",
+                    "type":        "boolean"
+                },
+
         "noop": {
             "description": "Whether the puppet run was started in noop mode",
             "type":        "boolean"

lib/puppet/transaction/report.rb

@@ -218,7 +218,7 @@ def initialize(configuration_version=nil, environment=nil, transaction_uuid=nil,
     @external_times ||= {}
     @host = Puppet[:node_name_value]
     @time = Time.now
-    @report_format = 7
+    @report_format = 8
     @puppet_version = Puppet.version
     @configuration_version = configuration_version
     @transaction_uuid = transaction_uuid
@@ -243,6 +243,7 @@ def initialize_from_hash(data)
     @transaction_uuid = data['transaction_uuid']
     @environment = data['environment']
     @status = data['status']
+    @transaction_completed = data['transaction_completed']
     @noop = data['noop']
     @noop_pending = data['noop_pending']
     @host = data['host']
@@ -304,6 +305,7 @@ def to_data_hash
       'report_format' => @report_format,
       'puppet_version' => @puppet_version,
       'status' => @status,
+      'transaction_completed' => @transaction_completed,
       'noop' => @noop,
       'noop_pending' => @noop_pending,
       'environment' => @environment,

spec/unit/transaction/report_spec.rb

@@ -587,6 +587,7 @@ def expect_equivalent_reports(tripped, report)
     expect(tripped.report_format).to eq(report.report_format)
     expect(tripped.puppet_version).to eq(report.puppet_version)
     expect(tripped.status).to eq(report.status)
+    expect(tripped.transaction_completed).to eq(report.transaction_completed)
     expect(tripped.environment).to eq(report.environment)
     expect(tripped.corrective_change).to eq(report.corrective_change)