Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update splaylimit during daemon run #9345

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mhashizume
Copy link
Contributor

Prior to this commit, updates to splay settings in the Puppet configuration file (puppet.conf) would not get picked up in a daemonized Puppet run.

This commit updates the daemon class to call a new public method in the splay job class to update the splaylimit.

@mhashizume mhashizume added the bug Something isn't working label May 13, 2024
@joshcooper
Copy link
Contributor

ah nice, makes sense

@mhashizume mhashizume force-pushed the PUP-11728/main/splay branch 2 times, most recently from aae86b0 to de3ac97 Compare May 14, 2024 21:57
@mhashizume mhashizume marked this pull request as ready for review May 14, 2024 21:57
@mhashizume mhashizume requested a review from a team as a code owner May 14, 2024 21:57
Prior to this commit, updates to splay settings in the Puppet
configuration file (puppet.conf) would not get picked up in a daemonized
Puppet run.

This commit updates the daemon class to call a new public method in the
splay job class to update the splaylimit.
@mhashizume mhashizume merged commit 7f0770c into puppetlabs:main Jun 3, 2024
9 checks passed
@mhashizume mhashizume deleted the PUP-11728/main/splay branch June 3, 2024 22:18
@joshcooper joshcooper added the backport 7.x Generate a backport PR to 7.x label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Successfully created backport PR for 7.x:

mhashizume added a commit to mhashizume/puppet that referenced this pull request Jul 16, 2024
…main/splay"

This reverts commit 7f0770c, reversing
changes made to c260871.
tvpartytonight added a commit that referenced this pull request Jul 16, 2024
Revert "Merge pull request #9345 from mhashizume/PUP-11728/main/splay"
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
This reverts commit 7f0770c, reversing
changes made to c260871.

(cherry picked from commit a1a84cb)
mhashizume added a commit that referenced this pull request Jul 16, 2024
[Backport 7.x] Revert "Merge pull request #9345 from mhashizume/PUP-11728/main/splay"
joshcooper added a commit to joshcooper/puppet that referenced this pull request Sep 25, 2024
joshcooper added a commit to joshcooper/puppet that referenced this pull request Sep 26, 2024
joshcooper added a commit to joshcooper/puppet that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 7.x Generate a backport PR to 7.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants