-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update splaylimit during daemon run #9345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ah nice, makes sense |
mhashizume
force-pushed
the
PUP-11728/main/splay
branch
2 times, most recently
from
May 14, 2024 21:57
aae86b0
to
de3ac97
Compare
joshcooper
reviewed
May 15, 2024
mhashizume
force-pushed
the
PUP-11728/main/splay
branch
from
May 31, 2024 17:51
de3ac97
to
54283ff
Compare
joshcooper
reviewed
May 31, 2024
Prior to this commit, updates to splay settings in the Puppet configuration file (puppet.conf) would not get picked up in a daemonized Puppet run. This commit updates the daemon class to call a new public method in the splay job class to update the splaylimit.
mhashizume
force-pushed
the
PUP-11728/main/splay
branch
from
June 3, 2024 18:35
54283ff
to
7eb8ca0
Compare
joshcooper
approved these changes
Jun 3, 2024
Successfully created backport PR for |
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Sep 25, 2024
…/main/splay" This reverts commit a1a84cb.
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Sep 26, 2024
…/main/splay" This reverts commit a1a84cb.
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Oct 10, 2024
…/main/splay" This reverts commit abea432.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, updates to splay settings in the Puppet configuration file (puppet.conf) would not get picked up in a daemonized Puppet run.
This commit updates the daemon class to call a new public method in the splay job class to update the splaylimit.