Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MODULES-3548 #1498

Closed
wants to merge 2 commits into from
Closed

Fix MODULES-3548 #1498

wants to merge 2 commits into from

Conversation

floek
Copy link
Contributor

@floek floek commented Jul 7, 2016

Hi,

SLES 12 has Apache 2.4 Prefork installed. See:
https://tickets.puppetlabs.com/browse/MODULES-3548

I think this pull request fixes some of the issues.

Greetings

Floek

@binford2k
Copy link
Contributor

Can you fix the failing test by defining the operatingsystemmajrelease fact?

  1) apache::mod::ssl on a Suse OS should contain Class[apache::params]
     Failure/Error: it { is_expected.to contain_class('apache::params') }

     Puppet::PreformattedError:
       Evaluation Error: Unknown variable: '::operatingsystemmajrelease'. at /home/travis/build/puppetlabs/puppetlabs-apache/spec/fixtures/modules/apache/manifests/version.pp:39:11 on node testing-worker-linux-docker-a92e9a51-3399-linux-14.prod.travis-ci.org

@bmjen
Copy link
Contributor

bmjen commented Oct 6, 2016

@floek This PR looks good. Can you make the change that @binford2k suggested to the test?

@floek
Copy link
Contributor Author

floek commented Oct 6, 2016

Hi,

I'm a little short on time.I will have a look soon.

Floek

@HelenCampbell
Copy link
Contributor

Attempted to fix this up here: #1545

@HAIL9000
Copy link
Contributor

Closing this since #1545 has been merged. It covers all the commits in this PR plus a fix from @HelenCampbell.

Thanks for the contribution @floek!

@HAIL9000 HAIL9000 closed this Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants