Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Apply Engine Labels #43

Closed
RXM307 opened this issue Nov 16, 2017 · 3 comments
Closed

Unable to Apply Engine Labels #43

RXM307 opened this issue Nov 16, 2017 · 3 comments

Comments

@RXM307
Copy link
Contributor

RXM307 commented Nov 16, 2017

/modules/docker/templates/etc/sysconfig/docker.systemd.erb
Line: 25
Detail: undefined method `each' for "[owner=blah, myservice=1, role=myrole]":String
at /etc/puppetlabs/code/environments/test/modules/docker/manifests/service.pp:193:18

Similar to $dns should be able to set the docker.systemd.erb template as
<% if @labels %><% @labels_array.each do |label| %> --label <%= label %><% end %><% end -%>

and add the below to service.pp
$labels_array = any2array($labels)

Unless I've missed something?

@RXM307
Copy link
Contributor Author

RXM307 commented Nov 16, 2017

Fixed and tested in my Fork https://github.com/RXM307/puppetlabs-docker, Please Merge.
Still need to investigate why settings are being applied to /etc/sysconfig/docker instead of /etc/sysconfig/docker-latest though

@scotty-c
Copy link
Contributor

@RXM307 can you please raise a PR for the changes.

Thanks in advance

@RXM307 RXM307 changed the title Unable to Apply Labels Unable to Apply Engine Labels Nov 19, 2017
@RXM307
Copy link
Contributor Author

RXM307 commented Nov 20, 2017

Pull Request #48 Raised, will raise another issue for the sysconfig issues with some patches

davejrt added a commit that referenced this issue Nov 20, 2017
@davejrt davejrt closed this as completed Nov 28, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-docker that referenced this issue Apr 17, 2024
cegeka-jenkins pushed a commit to cegeka/puppet-docker that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants