Allow an option with a value of false to override something that mysql defaults to true rather than eliding it #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult to true instead of being elided, leaving the default.
|
Looks good, but please squash these commits. Also, do we need to document this? |
|
Shall I squash the undef change with them? I don't think the false change needs documenting since to me it's a bug fix and the previous behavior wasn't documented, but allowing undef in #427 seemed worth documenting to me as it'd be a new feature. |
|
okay, looking at the changes again, I think it's cool to leave them separate. |
igalic
added a commit
that referenced
this pull request
Jan 24, 2014
Allow an option with a value of false to override something that mysql defaults to true rather than eliding it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.