(PE-38155) Updating node_manager to use Latest Puppetlabs version #451
Conversation
ragingra
force-pushed
the
PE-38155
branch
3 times, most recently
from
050603a
to
b5f77d4
Compare
ragingra
force-pushed
the
PE-38155
branch
3 times, most recently
from
8b573f1
to
85ad784
Compare
ragingra
changed the title
Puppetfile
Outdated
| @@ -4,6 +4,6 @@ | |||
| # The following directive installs modules to the managed moduledir. | |||
| moduledir '.modules' | |||
|
|
|||
| mod 'WhatsARanjit/node_manager', '0.7.5' | |||
| mod 'node_manager', '1.0.1' | |||
There was a problem hiding this comment.
| mod 'node_manager', '1.0.1' | |
| mod 'puppetlabs/node_manager', '1.0.1' |
There was a problem hiding this comment.
Why is that Puppetfile even in this module?
There was a problem hiding this comment.
I believe the intention was to improve instructions around installation and usage. Will keep it for now, and move or remove when this is done.
There was a problem hiding this comment.
But where is that file used or documented? The installation instructions in /documentation/ use bolt project init .. --modules puppetlabs-peam. That command doesn't use the Puppetfile, only metadata.json.
There was a problem hiding this comment.
@bastelfreak I missed this comment, the documentation side hadn't been done as of yet. I'll raise a ticket to sort it.
Added rule purge to PE Infrastructure Agent
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
|
@ragingra @Jo-Lillie can you please explain why PRs are being merged when there are still open discussions? |
|
|
|
#451 https://github.com/puppetlabs/puppetlabs-peadm/pull/339/files#r1400527387 I'll try and make sure relevant discussions are properly wrapped up as we go forward |
Summary
Updating node_manager to use latest Puppetlabs version
Adding rule purge to PE Infrastructure Agent
Docs to be updated and add warning around PEADM controlling PE Infrastructure Agent
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?