Reduce the size of files on disk #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 29, 2020 16:33
Prior to this commit, the system metrics were pretty printed. This leads to additional consumed disk space. The json2timeseries STDIN expects that all data incoming is a single line. This commit changes the system metrics to log minified JSON.
Prior to this commit, the system metrics tidy was not functional. It would error out do to restrictions in the `metrics_tidy` script. This commit adds the system directories to the tidy script.
Prior to this commit, the JSON files were being backed up but only cleaned up every 90. This resulted in the same files being duplicated in each tarball for 90 days. This commit cleans up the json files to ensure that the tarballs only have a single days worth of data.
jarretlavallee
force-pushed
the
fix/master/pretty
branch
from
7876575
to
859beb0
Compare
m0dular
previously approved these changes
Jun 30, 2020
Sharpie
requested changes
Jul 15, 2020
files/metrics_tidy
Outdated
| @@ -55,3 +55,6 @@ find "$metrics_directory" -type f -ctime +"$retention_days" -delete | |||
| # The return code of a pipeline is the rightmost command, which means we trigger our trap if tar fails | |||
| find "$metrics_directory" -type f -name "*json" | \ | |||
| tar --create --gzip --file "${metrics_directory}/${metrics_type}-$(date +%Y.%m.%d.%H.%M.%S).tar.gz" --files-from - | |||
|
|
|||
| # Cleanup the backed up json files so that we do not duplicate files in the tarballs. | |||
| find "$metrics_directory" -type f -name "*json" -delete | |||
There was a problem hiding this comment.
I'm still not convinced running a separate find is the best way to do this since it can result in files being deleted before they are archived depending on how the cron jobs line up.
The old way of running find, saving the results to a file and then having tar and rm both operate on the list in that file seemed to work well. Is there a reason we can't return to using that?
There was a problem hiding this comment.
I agree, my concerns about xargs are probably unfounded in this case. Pushed a commit to this branch.
Revert to the behavior of storing the output of `find` in a temp file. This guarantees `tar` and `rm` operate on the same set of files to prevent data loss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the file size on disk by doing the following things: