Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purging occurs for prefixed sources when a 2nd non-prefix source shares basedirs #64

Closed
diginc opened this issue Sep 12, 2013 · 0 comments · Fixed by #73
Closed

Purging occurs for prefixed sources when a 2nd non-prefix source shares basedirs #64

diginc opened this issue Sep 12, 2013 · 0 comments · Fixed by #73

Comments

@diginc
Copy link

diginc commented Sep 12, 2013

RE: #53
This seems to bug purging if multiple sources share the same basedir directory and one has disabled prefixing, seems the non-prefixed source remains and the prefixed one gets deleted:

:cachedir: '/var/cache/r10k'
:sources:
  :hieradata: 
    remote: 'git@blabla1.git'
    basedir: '/etc/puppet/environments'
    prefix: true
  :modules: 
    remote: 'git@blabla2.git'
    basedir: '/etc/puppet/environments'
    prefix: false

:purgedirs:
  - '/etc/puppet/environments'

# Results in:
[R10K::Task::Deployment::PurgeEnvironments - INFO] Purging stale environments from /etc/puppet/environments
[R10K::Task::Deployment::PurgeEnvironments - DEBUG] Stale modules in /etc/puppet/environments: hieradata_dev, hieradata_prod, hieradata_master
[R10K::Task::Deployment::PurgeEnvironments - DEBUG] No stale environments in /etc/puppet/environments
# Leaving:
$ ls /etc/puppet/environments/
dev  master  prod

I only bring this up because I had trouble getting a modulepath with a prefix working like:
[master] modulepath = /etc/puppet/environments/modules_$environment/modules

(running latest master version through bundle)

~/r10k/lib/r10k$ git log | head -1
commit 68b8f0ecbce44f4c99c740b8765e5e48306249b4
~/r10k/lib/r10k$ git branch
* master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant