Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5947) Added condition for Amazon Linux in project.spec.erb #828

Conversation

span786
Copy link
Contributor

@span786 span786 commented Nov 17, 2023

Added condition for Amazon Linux in project.spec.erb

Copy link
Contributor

@e-gris e-gris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct change.

However, I must admit to a small level of discomfort in us having established patterns here contrary to generally preferred Ruby idioms.

@mhashizume
Copy link
Contributor

Running this PR in an ad hoc agent pipeline, we're still seeing the same failures:

03:26:52     PL Repo for puppet-agent at commit 97ecc7900909 925 kB/s |  61 kB     00:00    
03:26:53     Error: 
03:26:53      Problem: conflicting requests
03:26:53       - nothing provides /bin/mkdir needed by puppet-agent-7.27.0.37.g97ecc7900-1.amazon2023.x86_64
03:26:53     (try to add '--skip-broken' to skip uninstallable packages)

We need to do more investigation to find a fix before merging this PR.

@mhashizume
Copy link
Contributor

@span786 was able to get a working build for Amazon x86_64 and aarch64.

LGTM!

@mhashizume mhashizume merged commit 59a0f9b into puppetlabs:main Nov 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants