Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar theming #19

Merged
merged 2 commits into from
Nov 1, 2016
Merged

Scrollbar theming #19

merged 2 commits into from
Nov 1, 2016

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented Nov 1, 2016

@Yukaii Yukaii added this to the v1.0 milestone Nov 1, 2016
@Yukaii
Copy link
Member Author

Yukaii commented Nov 1, 2016

這邊先到這裡，未來可以優化的方向：

  1. App start 時就要載入目前的兩岸設定。準備好預設的 style sheet 讓 BrowserWindow inject
  2. 需要兩份 overlap 的 Theme
  3. Extract 這個邏輯出來成 mixin 或 helper。

@Yukaii Yukaii merged commit 227b064 into master Nov 1, 2016
@Yukaii Yukaii deleted the scrollbar-theming branch November 1, 2016 01:34
@Yukaii
Copy link
Member Author

Yukaii commented Nov 1, 2016

這個 PR 的結論是：在寫 Web Application，對 DOM 的直接操作總是無可避免的。框架、函式庫只是輔助。之前一直沒有用過 vanilla js，總在依賴 jQuery，這次才發現很多時候其實不需要啊 😆

@Yukaii Yukaii mentioned this pull request Nov 1, 2016
Open
36 tasks
@Yukaii
Copy link
Member Author

Yukaii commented Nov 1, 2016

補張圖：

puraku-scrollbar-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.7
Development

Successfully merging this pull request may close these issues.
1 participant
@Yukaii