Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line-marking faces overriding other faces #5

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

ubolonton
Copy link
Contributor

This is especially useful when multiple fonts are used (e.g. for icons, proportional texts).

marked

This is especially useful when multiple fonts are used (e.g. for icons, proportional texts).
@purcell
Copy link
Owner

purcell commented Feb 9, 2018

Looks good to me - thanks for this! Merging now.

@purcell purcell merged commit e891cbb into purcell:master Feb 9, 2018
@manuel-uberti
Copy link

I have this now:
screenshot

Basically: marked lines are not clear anymore.

@ubolonton
Copy link
Contributor Author

@manuel-uberti How did it previously look for you? If you want to override more properties (e.g. foreground), you can still do that by customizing the faces.

@manuel-uberti
Copy link

manuel-uberti commented Feb 9, 2018

Before, the 3 directories marked with D had the same colour as manuel in the above screenshot.

@ubolonton
Copy link
Contributor Author

I just created another PR to fix this.

@manuel-uberti
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants