Enable xref-js2 in js-ts-mode #850
Conversation
lisp/init-javascript.el
Outdated
| (add-hook 'js-mode-hook 'sanityinc/enable-xref-js2)) | ||
| (define-key js-ts-mode-map (kbd "M-.") nil) | ||
| (add-hook 'js-mode-hook 'sanityinc/enable-xref-js2) | ||
| (add-hook 'js-ts-mode-hook 'sanityinc/enable-xref-js2)) |
There was a problem hiding this comment.
js-mode-hook is actually run in js-ts-mode
There was a problem hiding this comment.
No, actually both js-mode and js-ts-mode inherit from js-base-mode in Emacs >= 29
There was a problem hiding this comment.
Ah yes, sorry, I had been tinkering with the code locally and my mind was thinking of js-base-mode.
lisp/init-javascript.el
Outdated
| @@ -57,7 +57,10 @@ | |||
| (add-hook 'xref-backend-functions #'xref-js2-xref-backend nil t)) | |||
| (with-eval-after-load 'js | |||
| (define-key js-mode-map (kbd "M-.") nil) | |||
| (add-hook 'js-mode-hook 'sanityinc/enable-xref-js2)) | |||
| (define-key js-ts-mode-map (kbd "M-.") nil) | |||
There was a problem hiding this comment.
This would break in Emacs < 29 so a different formulation would be needed.
There was a problem hiding this comment.
Thanks for the reminder, I have fixed this problem, please take a look.
|
I pushed my version of this change in |
He doesn't fix the problem, because (defvar js-ts-mode-map (copy-keymap js-mode-map)
"Keymap used in `js-ts-mode'.")I think this could work: (let ((base-mode (if (fboundp 'js-base-mode) 'js-base-mode 'js-mode)))
(with-eval-after-load 'js
(add-hook (derived-mode-hook-name base-mode) 'sanityinc/enable-xref-js2)
(define-key js-mode-map (kbd "M-.") nil)
+ (define-key js-ts-mode-map (kbd "M-.") nil)
))But there is another good news. In the emacs master branch, the commit |
|
Thanks. I committed a further fix here anyway. |
No description provided.