Add support for allowed package-to-symbol prefix mappings #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid mappings are stored in
`package-lint--allowed-prefix-mappings`. Its default value is:
'(("ox-" . ("org-"))
("ob-" . ("org-")))
This means that in packages starting with "ox-" and "ob-", functions
and symbols starting with "org-" are allowed. After the mapping, the
symbols still must match the whole package match. For example, in
package "ox-foobar", symbols starting with "org-foobar" will be
allowed.
Fixes purcell#89.
|
Nice, thanks. Would you be able to provide a few little tests please? It should be pretty easy with the setup we've got: just load up |
Added one positive and one negative test.
|
@purcell thanks for the pointer - I've added two checks, one for a valid prefix mapping and one for an invalid one. Please let me know if anything should be changed or done differently. |
Fanael
reviewed
Jun 10, 2020
|
Thanks! |
1 similar comment
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valid mappings are stored in
package-lint--allowed-prefix-mappings. Its default value is:This means that in packages starting with "ox-" and "ob-", functions and symbols starting with "org-" are allowed. After the mapping, the symbols still must match the whole package match. For example, in package "ox-foobar", symbols starting with "org-foobar" will be allowed.
Fixes #89.