Add support for functions provided by the compat package #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purcell
force-pushed
the
compat-support
branch
2 times, most recently
from
34f5929
to
d62999f
Compare
minad
reviewed
Nov 3, 2023
package-lint.el
Outdated
| (insert-file-contents el-path) | ||
| (goto-char (point-min)) | ||
| ;; TODO convert to rx | ||
| (while (search-forward-regexp "^(compat-\\(defun\\|\\defvar\\) +\\_<\\(.*?\\)\\_>" nil t) |
There was a problem hiding this comment.
Also compat-defmacro should be added here.
There was a problem hiding this comment.
Ah yes! I should find an example and add a test.
There was a problem hiding this comment.
And I've ignored variables, which aren't actually handled in the existing code.
purcell
force-pushed
the
compat-support
branch
from
d62999f
to
dd65423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #227