Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸Unique error for kernel mismatch when applying a template #276

Merged
merged 33 commits into from
Oct 5, 2023
Merged

🚸Unique error for kernel mismatch when applying a template #276

merged 33 commits into from
Oct 5, 2023

Conversation

ceaglebu
Copy link
Contributor

@ceaglebu ceaglebu commented Mar 10, 2023 •
edited by Jackman3323
Loading

#### Summary:
Added a unique error message when the kernel version of the project is not supported by the template.

Motivation:

More intuitive to diagnose issues when installing templates.

References (optional):

closes #273

Test Plan:

  • applying local and online templates that do not support project's kernel version should cause new error
    Screenshot 2023-03-06 220628
  • applying a template that does support project's kernel version should still work
    Screenshot 2023-03-06 220550
  • fetching a template should still work
    Screenshot 2023-03-06 220439
  • old error message should still work
    Screenshot 2023-03-06 220718

ayushuk and others added 13 commits March 2, 2023 14:07
@ayushuk
Uninstall charset_normalizer
a8dd15f
@ayushuk
Merge pull request #274 from purduesigbots/bugfix/fix-ci-macos-univer…
b08bb8d 
…sal-dependency-error

🐛 Fix macos CI universal dependency errors
@ceaglebu
Added KernelMismatchException to catch when no templates are found due
d872334 
to a kernal mismatch. This causes a different error message than if no
templates are found because they don't exist.
@ceaglebu
Sucessfully builds project, have not tested adding incompatible template
19294d5
@ceaglebu
Moved error handling to resolve_templates. Still needs testing with t…
f4121da 
…emplate
@ceaglebu
Optimization changes
4718079
@ceaglebu
removed unnecessary exception
b35ac2b
@ceaglebu
Update template_resolution.py
8301c66 
undoing unnecessary changes
@ceaglebu
Removed need for filtering twice
b9988bf
@ceaglebu
Merge branch 'feature/kernel-mismatch-error' of https://github.com/pu…
8cee778 
…rduesigbots/pros-cli into feature/kernel-mismatch-error
@ceaglebu
Removed unnecessary files
ff943bc
@ceaglebu
removed unnecessary files
9090e51
@ceaglebu
asdf
fc85aff
@ceaglebu ceaglebu linked an issue Mar 10, 2023 that may be closed by this pull request
✨Kernel Mismatch error when applying a template #273
Closed
@SizzinSeal
Copy link
Contributor

Just want to add some extra motivation to this: This is by far the most common issue people have when installing LemLib and its a huge hassle for both the devs and the users

ayushuk
ayushuk approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and tested on the latest version of develop

@ayushuk ayushuk merged commit 5ee1865 into develop Oct 5, 2023
10 checks passed
@ayushuk ayushuk deleted the feature/kernel-mismatch-error branch October 5, 2023 16:20
This was referenced Jan 19, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushuk ayushuk ayushuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨Kernel Mismatch error when applying a template
5 participants
@ceaglebu @SizzinSeal @ayushuk @kunwarsahni01 @noam987