🚸 Clarify rotation_get_angle API #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, pretty straight forward and well needed fix. |
WillXuCodes
approved these changes
Nov 9, 2020
|
Note: Should probably update the docs too with the same wording. |
WillXuCodes
changed the title
baylessj
approved these changes
Nov 29, 2020
Closed
Merged
HotelCalifornia
added a commit
that referenced
this pull request
Feb 28, 2021
* Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🔖 Bumped version to 3.4.0 * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨ Add microsecond timing (#281) * Add micros as a wrapper to vexSystemHighResTimeGet * Add micros using to rtos.hpp * Fix comment formatting * Add necessary include for VEXos function Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com>
Merged
WillXuCodes
added a commit
that referenced
this pull request
Mar 9, 2021
* Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🔖 Bumped version to 3.4.0 * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨ Add microsecond timing (#281) * Add micros as a wrapper to vexSystemHighResTimeGet * Add micros using to rtos.hpp * Fix comment formatting * Add necessary include for VEXos function Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com>
WillXuCodes
added a commit
that referenced
this pull request
Jul 19, 2021
* Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * 🔖 Release 3.4.0 (#279) (#283) * Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🔖 Bumped version to 3.4.0 * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨ Add microsecond timing (#281) * Add micros as a wrapper to vexSystemHighResTimeGet * Add micros using to rtos.hpp * Fix comment formatting * Add necessary include for VEXos function Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> * ⬆️ upgrade VEXos to 1.0.13 (#289) * Add rotation data rate function (#290) * ✨ Allow user code to query registry status (#282) * Move registry_get_bound_type and registry_get_plugged_type to apix.h * Fix docs for registry functions to reflect their zero-indexed port number * 🚸 add pros::IMU alias (#293) * Create alias for Imu in IMU.h and IMU.hpp * Revert version changes * Fix version number and add typdef to pros namespace * Revert typdef location to inside class * Move alias statement, remove c implementation Move the alias statement in imu.hpp outside of IMU class. Remove c implementation of alias. Resolves #288 * Add newline in version * Fix indent of alias * 🔥 Deprecate PID setting functions (#294) * Keep functionality along with deprecation tags * Add message to deprecation warning * Deprecate other functions related to pid setting * ✨Added Delay to IMU Reset (#286) * added delay to IMU reset * variable delay * change comments * ✨Add Simplified Screen API Option (#299) ✨Add Simplified Screen API Option (#299) Co-authored-by: Ayush Shukla <ayushshukla30339@gmail.com> * 🔖 Release 3.5.0 Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: AyushShukla3 <71904196+AyushShukla3@users.noreply.github.com> Co-authored-by: Eric Dong <aderic6@gmail.com>
WillXuCodes
added a commit
that referenced
this pull request
Aug 12, 2021
* 🔖 Release 3.4.0 (#279) * Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🔖 Bumped version to 3.4.0 * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨ Add microsecond timing (#281) * Add micros as a wrapper to vexSystemHighResTimeGet * Add micros using to rtos.hpp * Fix comment formatting * Add necessary include for VEXos function Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> * 🔖 Release 3.5.0: Quality Post Event Update (#300) * Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * 🔖 Release 3.4.0 (#279) (#283) * Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🔖 Bumped version to 3.4.0 * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨ Add microsecond timing (#281) * Add micros as a wrapper to vexSystemHighResTimeGet * Add micros using to rtos.hpp * Fix comment formatting * Add necessary include for VEXos function Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> * ⬆️ upgrade VEXos to 1.0.13 (#289) * Add rotation data rate function (#290) * ✨ Allow user code to query registry status (#282) * Move registry_get_bound_type and registry_get_plugged_type to apix.h * Fix docs for registry functions to reflect their zero-indexed port number * 🚸 add pros::IMU alias (#293) * Create alias for Imu in IMU.h and IMU.hpp * Revert version changes * Fix version number and add typdef to pros namespace * Revert typdef location to inside class * Move alias statement, remove c implementation Move the alias statement in imu.hpp outside of IMU class. Remove c implementation of alias. Resolves #288 * Add newline in version * Fix indent of alias * 🔥 Deprecate PID setting functions (#294) * Keep functionality along with deprecation tags * Add message to deprecation warning * Deprecate other functions related to pid setting * ✨Added Delay to IMU Reset (#286) * added delay to IMU reset * variable delay * change comments * ✨Add Simplified Screen API Option (#299) ✨Add Simplified Screen API Option (#299) Co-authored-by: Ayush Shukla <ayushshukla30339@gmail.com> * 🔖 Release 3.5.0 Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: AyushShukla3 <71904196+AyushShukla3@users.noreply.github.com> Co-authored-by: Eric Dong <aderic6@gmail.com> * Changed IMU port claim to rotation port claim Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: AyushShukla3 <71904196+AyushShukla3@users.noreply.github.com> Co-authored-by: Eric Dong <aderic6@gmail.com>
WillXuCodes
added a commit
that referenced
this pull request
Jun 11, 2022
* Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🔖 Bumped version to 3.4.0 * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨ Add microsecond timing (#281) * Add micros as a wrapper to vexSystemHighResTimeGet * Add micros using to rtos.hpp * Fix comment formatting * Add necessary include for VEXos function Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com>
WillXuCodes
added a commit
that referenced
this pull request
Jun 11, 2022
* Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * 🔖 Release 3.4.0 (#279) (#283) * Clarify rotation_get_angle API (#264) * Fixed all instances of the liscense being outdated in file headers. (#272) * 👽 Add missing filesystem syscalls (#275) * Add missing file system stubs * Update src/system/dev/file_system_stubs.c Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Put fchmod and fchmodat by chmod Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * ✨ Add Zeroing and Position Setting Functions for the IMU (#260) * Started on getter, setter, and zeroing features for IMU offset and read values respectively for the cpp api only. * Added comments to header files for all new functions and finished up setter functions. * Fixed documentation and removed extraneous ::IMU * version fix * Version Fix (anotha one) * Update version * Update version * Update version * Changed IMU offsets to initializer list * Reordered initializer list * Fixed a few file headers, changed CPP back to previous state, renamed reset function to calibrate, and started work on thread safe reset functions. * Added working C functions for resetting rotation and header. * C api for yaw, pitch, and roll reset working. * Added a new imu_reset function that resets all values from the IMU. * Added resets for CPP api (not tested yet) * Fixed build issue * Properly fixed the issue now. * Added setter functions for value readings, reworked reset functions accordingly. * Added missing semicolon, finished testing C API. * Added CPP api for setting values. * Added documentation for reset and set value functions. * Added imubl (IMU Backend Layer) for non-threadsafe functions, and also added documentation for those functions. Made get_euler thread safe again with a new seperate function for non-threadsafe use. * Added untracked file (IMUBL) * Fixed up all other debugging * Changed imubl location to VDML to hide it from users. * Changed imubl header description * Reverted version and drive code. * Added newlines back to the end of files * Updated Header Liscense Years * Revert "Updated Header Liscense Years" This reverts commit 36074f0. * Packed the enum for imu reset data, fixed formatting and newline at end of imu.hpp. * Revert accidental change to get_accel docs. * Removed imubl and fixed packed attribute * Changed mentions of reset back to tare, and changed calibrate back to tare. * Revert drive code * Revert version * Revert version properly * Update include/pros/imu.hpp Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * Combined the declarations and definitions for device pointers. * Fixed offset for get euler, and also changed the quaternion function to involve offsets. (TO BE TESTED, no V5 on hand). * Finished testing and fixing quaternion, revert version and drive code. * Fixed indentation * Added euler setting and taring functions. * Added limits to the setting functions. * Added proper limiting (still needs work though) * Added proper value wrapping for when a value + offset exceeds a measurable range. * Revert version and drive code, added and tested C++ API for euler. * Added documentation about setter behaviors. * Added newline at end of vdml_imu.c * Stylization changes. * Fixed inconsistent sentence Co-authored-by: nathan-moore <nathanmoore424@gmail.com> * 🔖 Bumped version to 3.4.0 * 🚸Change pros-cli-v5 to pros-cli (#277) * Changed pros-v5-cli to pros-cli Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨ Add microsecond timing (#281) * Add micros as a wrapper to vexSystemHighResTimeGet * Add micros using to rtos.hpp * Fix comment formatting * Add necessary include for VEXos function Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> * ⬆️ upgrade VEXos to 1.0.13 (#289) * Add rotation data rate function (#290) * ✨ Allow user code to query registry status (#282) * Move registry_get_bound_type and registry_get_plugged_type to apix.h * Fix docs for registry functions to reflect their zero-indexed port number * 🚸 add pros::IMU alias (#293) * Create alias for Imu in IMU.h and IMU.hpp * Revert version changes * Fix version number and add typdef to pros namespace * Revert typdef location to inside class * Move alias statement, remove c implementation Move the alias statement in imu.hpp outside of IMU class. Remove c implementation of alias. Resolves #288 * Add newline in version * Fix indent of alias * 🔥 Deprecate PID setting functions (#294) * Keep functionality along with deprecation tags * Add message to deprecation warning * Deprecate other functions related to pid setting * ✨Added Delay to IMU Reset (#286) * added delay to IMU reset * variable delay * change comments * ✨Add Simplified Screen API Option (#299) ✨Add Simplified Screen API Option (#299) Co-authored-by: Ayush Shukla <ayushshukla30339@gmail.com> * 🔖 Release 3.5.0 Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: nathan-moore <nathanmoore424@gmail.com> Co-authored-by: Andrew Strauss <astrauss11@gmail.com> Co-authored-by: AyushShukla3 <71904196+AyushShukla3@users.noreply.github.com> Co-authored-by: Eric Dong <aderic6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR clarifies the return value of
rotation_get_angle.Motivation:
This was unclear to me before talking with @HotelCalifornia