Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run against all passing tests in PureScript compiler test suite #12

Closed
3 tasks done
felixSchl opened this issue Sep 3, 2018 · 8 comments
Closed
3 tasks done
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority

Comments

@felixSchl
Copy link
Collaborator

felixSchl commented Sep 3, 2018

All of these tests should eventually pass using this backend: https://github.com/purescript/purescript/tree/master/tests/purs/passing.

The directory structure is set up such that every (NAME).purs file is a test with additional supporting modules optionally residing in a folder named (NAME)/ in the same directory.

The logic for this already exists for the most part: https://github.com/felixSchl/purescript-c/blob/5ccdd0584d856584259096eadd11d316375f476d/test/Main.purs#L49-L57.

  • Resolve dependencies (do all tests just rely on prelude?)
  • Compile Makefiles (Generate Makefiles #13)
  • Generate test suite using purescript-spec (each test case should become an it block)
@felixSchl felixSchl added help wanted Extra attention is needed good first issue Good for newcomers priority labels Sep 3, 2018
@felixSchl felixSchl changed the title Run against all passing test in PureScript compiler test suite Run against all passing tests in PureScript compiler test suite Sep 4, 2018
felixSchl pushed a commit that referenced this issue Sep 5, 2018
@felixSchl
Copy link
Collaborator Author

Everything's set up now to work through the tests fixing anything that comes up. The biggest problem now is not having implemented the FFI of many of the dependencies. This is where fun becomes work and contributions would be very welcomed.

felixSchl pushed a commit that referenced this issue Sep 6, 2018
Useful to plot the dependency graph of a package in order to plan
out implementing the C FFI of common packages (at least enough of
them to complete #12).
@felixSchl
Copy link
Collaborator Author

felixSchl commented Sep 6, 2018

deps

  • #f03c15 todo
  • #c5f015 done

@felixSchl
Copy link
Collaborator Author

We're starting to look really good. @Lupino do you feel up to doing more? I am thinking of taking a stab at purescript-st next.

@felixSchl
Copy link
Collaborator Author

I've created a number of issues and an encompassing project. If you want to work on any of the issues please make sure it's not already assigned.

@felixSchl
Copy link
Collaborator Author

Yay, we're 239/266 tests passing! A few sigsegvs here (likely stack overflows) and a few sigabrt there (likely failed asserts), a missing implementation for ObjectUpdate, a few missing FFIs for tests themselves, as well as a missing implementations for purescript-arrays (#36), purescript-strings (#34), and we'll be there before we know it!

@felixSchl
Copy link
Collaborator Author

We're at 255/266 with @Lupino's work on purescript-arrays. Almost there! :)

@felixSchl
Copy link
Collaborator Author

We're at 256/266 as of 993d1fd.

What's next: I think the missing FFI tests will fall relatively quickly, but there's some corefn parsing issues which might cause a larger hold up, for example: paulyoung/purescript-corefn#57.

@felixSchl
Copy link
Collaborator Author

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority
Projects
None yet
Development

No branches or pull requests

1 participant