Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input type="submit" should works as button #54

Closed
lkdjiin opened this issue Jun 2, 2013 · 6 comments
Closed

input type="submit" should works as button #54

lkdjiin opened this issue Jun 2, 2013 · 6 comments
Labels
Milestone

Comments

@lkdjiin
Copy link

lkdjiin commented Jun 2, 2013

I think the rendering of

<input class="pure-button pure-button-primary" type="submit" value="..." />

should be the same as

<button class="pure-button pure-button-primary">...</button>
@codepb
Copy link
Contributor

codepb commented Jun 3, 2013

I have checked this and I believe that is the case? Where are you seeing a difference? I've added an input to the tests in mine, and it all looks the same.

@lkdjiin
Copy link
Author

lkdjiin commented Jun 3, 2013

Out of a form, they look the same, but not in a form. Tested in firefox and chrome.
Check this simple example : https://gist.github.com/lkdjiin/5700609
I'll investigate if I find the time...

@codepb
Copy link
Contributor

codepb commented Jun 3, 2013

Yes, you are right, the issue is the '.pure-form input' style that is applied. To resolve this the '.pure-form input' style would have to be targeted to specific input types. Example jsFiddle: http://jsfiddle.net/ncHE3/

@tilomitra
Copy link
Contributor

Good catch. I didn't specify the specific input types because I figured we would save some k-weight. This looks like a bug, so I'll look into this.

@ghost ghost assigned tilomitra Jun 4, 2013
@ericf
Copy link
Collaborator

ericf commented Jun 4, 2013

Looks like more than just submit buttons: http://jsfiddle.net/ncHE3/1/

The button style should be applied to the following inputs:

  • input[type=button]
  • input[type=reset]
  • input[type=submit]

tilomitra added a commit to tilomitra/pure that referenced this issue Jun 5, 2013
This adds a lot more rules but I'm hoping that gzipping
will not affect the k-weight much. This commit fixes
issue pure-css#54 (pure-css#54)
tilomitra added a commit to tilomitra/pure that referenced this issue Jun 5, 2013
@ericf
Copy link
Collaborator

ericf commented Jun 8, 2013

#64 was merged, so closing this…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants