-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No global grunt dep #203
No global grunt dep #203
Conversation
@@ -3,6 +3,9 @@ | |||
"version": "0.3.1-pre", | |||
"private": true, | |||
"repository": "git://github.com/yui/pure.git", | |||
"scripts": { | |||
"test": "grunt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be grunt test
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is intentional: test
because it is the default and only grunt
because it runs the build task and not only the lint one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But Pure doesn't need to be built to run its tests, the tests are only ran on the contents of the src/
dir. Can you switch this test script to grunt test
? Then I'll merge this in.
@albertosantini So what's the reasoning for wanting to do this? Just to not force people to have previously run |
Correct, but with the local dep the project is indipendent: for instance, any project may use different versions of grunt. There is also another reason: after cloning the repo, I execute |
Thanks @albertosantini! |
Credit to Matt Goldspink's post and Tim Branyen's comment.
http://www.mattgoldspink.co.uk/2013/02/10/using-travis-ci-with-grunt-0-4-x/