Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No global grunt dep #203

Merged
merged 3 commits into from
Sep 27, 2013
Merged

No global grunt dep #203

merged 3 commits into from
Sep 27, 2013

Conversation

albertosantini
Copy link
Contributor

Credit to Matt Goldspink's post and Tim Branyen's comment.

http://www.mattgoldspink.co.uk/2013/02/10/using-travis-ci-with-grunt-0-4-x/

@@ -3,6 +3,9 @@
"version": "0.3.1-pre",
"private": true,
"repository": "git://github.com/yui/pure.git",
"scripts": {
"test": "grunt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be grunt test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is intentional: test because it is the default and only grunt because it runs the build task and not only the lint one.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But Pure doesn't need to be built to run its tests, the tests are only ran on the contents of the src/ dir. Can you switch this test script to grunt test? Then I'll merge this in.

@ericf
Copy link
Collaborator

ericf commented Sep 26, 2013

@albertosantini So what's the reasoning for wanting to do this? Just to not force people to have previously run npm i -g grunt-cli?

@albertosantini
Copy link
Contributor Author

Correct, but with the local dep the project is indipendent: for instance, any project may use different versions of grunt.

There is also another reason: after cloning the repo, I execute npm install and npm test without worrying about the tools I should install.

@ericf
Copy link
Collaborator

ericf commented Sep 27, 2013

Thanks @albertosantini!

ericf added a commit that referenced this pull request Sep 27, 2013
@ericf ericf merged commit ea37411 into pure-css:master Sep 27, 2013
@albertosantini albertosantini deleted the no-global-grunt-dep branch September 27, 2013 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants