Print warnings when s.t. uses FFI but has no FFI file, or vice versa. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be done in a much easier fashion by simply checking for FFI declarations straight away in `convert`. However, I want to later be able to perform other checks at later stages of the conversion process, so I'm setting up some infrastructure for that as well. Specifically, when checking whether strings contain interpolataions, we want to take not of that so we can emit warnings later, but that's coming in a separate PR.
jonascarpay
force-pushed
the
jc/FFI-warnings
branch
from
cf99f81
to
9d26028
Compare
jonascarpay
changed the title
cdepillabout
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
This could be done in a much easier fashion by simply checking for FFI
declarations straight away in
convert. However, I want to later beable to perform other checks at later stages of the conversion process,
so I'm setting up some infrastructure for that as well. Specifically,
when checking whether strings contain interpolataions, we want to take
not of that so we can emit warnings later, but that's coming in a
separate PR.