Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove JSAccessor, replacing its usages with JSIndexer #2513

Closed
michaelficarra opened this issue Dec 30, 2016 · 0 comments
Closed

remove JSAccessor, replacing its usages with JSIndexer #2513

michaelficarra opened this issue Dec 30, 2016 · 0 comments
Labels
codegen type: enhancement
Milestone
1.0

Comments

@michaelficarra
Copy link
Contributor

We can then render instances of JSIndexer with a StringLiteral as static member access when the ECMAScript grammar allows for it. See discussion at #2488 (comment). I'll send a PR once I'm done with #2488.
@paf31 paf31 added this to the Ideas milestone Dec 30, 2016
michaelficarra added a commit to michaelficarra/purescript that referenced this issue Jan 8, 2017
@michaelficarra
fixes purescript#2513: remove JSAccessor; replace with JSIndexer
0808cba
@michaelficarra michaelficarra mentioned this issue Jan 8, 2017
Merged
michaelficarra added a commit to michaelficarra/purescript that referenced this issue Jan 9, 2017
@michaelficarra
generate static member accesses when possible (ref purescript#2513)
84fb7b7
michaelficarra added a commit to michaelficarra/purescript that referenced this issue Jan 9, 2017
@michaelficarra
fixes purescript#2513: remove JSAccessor; replace with JSIndexer
f7a13df
michaelficarra added a commit to michaelficarra/purescript that referenced this issue Jan 9, 2017
@michaelficarra
generate static member accesses when possible (ref purescript#2513)
3c9f14b
michaelficarra added a commit to michaelficarra/purescript that referenced this issue Jan 14, 2017
@michaelficarra
Merge branch 'master' into purescriptGH-2513
c03327f
paf31 pushed a commit that referenced this issue Jan 14, 2017
@michaelficarra @paf31
remove JSAccessor; replace with JSIndexer (#2554)
1bb6acd 
* fixes #2513: remove JSAccessor; replace with JSIndexer

* generate static member accesses when possible (ref #2513)

* remove duplicate function isFn
@paf31 paf31 modified the milestones: 1.0, Ideas Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen type: enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@michaelficarra @paf31