Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In error/warning link text, correctly say "error" or "warning" #1424

Merged
merged 1 commit into from
Aug 25, 2015

Conversation

mjgpy3
Copy link
Contributor

@mjgpy3 mjgpy3 commented Aug 25, 2015

Pretty simple, I got confused for a second when a warning said

... for more information, or to contribute content related to this error.

This change makes the text say contribute content related to this (error|warning). depending on the level.

e.g.

Error found:
Error in module Main:
Error at /home/michael/dev/contrib/purescript/Foobar.purs line 3, column 8 - line 3, column 13:
  Unknown value (+)
See https://github.com/purescript/purescript/wiki/Error-Code-UnknownValue for more information, or to contribute content related to this error.

and

Compiling Main
Warning found:
Warning in module Main:
Warning in value declaration a:
Warning at /home/michael/dev/contrib/purescript/Foobar.purs line 3, column 1 - line 3, column 8:
    Pattern could not be determined to cover all cases.
    The definition has the following uncovered cases:

    _
See https://github.com/purescript/purescript/wiki/Error-Code-NotExhaustivePattern for more information, or to contribute content related to this warning.

@paf31
Copy link
Contributor

paf31 commented Aug 25, 2015

Thanks!

paf31 added a commit that referenced this pull request Aug 25, 2015
In error/warning link text, correctly say "error" or "warning"
@paf31 paf31 merged commit 6bbe003 into purescript:master Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants