Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #490 #603

Merged
merged 1 commit into from
Sep 21, 2014
Merged

Fix #490 #603

merged 1 commit into from
Sep 21, 2014

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented Sep 20, 2014

@garyb @joneshf Does this look ok? It allows us to make binary distributions which copy the Prelude to the user's home directory or the XDG config directory.

@joneshf I was thinking as well, maybe what we could do with XDG is to turn support on/off based on a cabal flag. What do you think?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 8bf954a on bindists into caa1dc6 on master.

@joneshf
Copy link
Member

joneshf commented Sep 21, 2014

I think since people are still having issues with the xdg library, we should just can it all together like in the last PR you did, until whatever install problems are fixed with the library, or someone writes a new one. I mean, this isn't doing "The Right Thing" on osx I don't think. Also, I think I might have said XDG_CONFIG_HOME before, but I think prelude belongs in XDG_DATA_HOME, since it's something that shouldn't be deleted.

Maybe the xdg library problem is actually not an issue if we're shipping binaries anyway?

In any case, I think it looks good enough to merge. 👍 Especially if it gets binaries for other platforms!

@paf31
Copy link
Contributor Author

paf31 commented Sep 21, 2014

@garyb Would you mind giving this a quick test on Windows please, if you have time? I've only tested on Mac and Linux. Thanks.

@garyb
Copy link
Member

garyb commented Sep 21, 2014

Sure thing.

@garyb
Copy link
Member

garyb commented Sep 21, 2014

Yep, it's all good. As a test I moved the prelude.purs around and it resolved from ~/.purescript etc. as intended too.

@paf31
Copy link
Contributor Author

paf31 commented Sep 21, 2014

Excellent, thanks.

paf31 added a commit that referenced this pull request Sep 21, 2014
@paf31 paf31 merged commit 30c1cd5 into master Sep 21, 2014
@paf31 paf31 deleted the bindists branch September 21, 2014 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants