Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple errors during name resolution #666

Merged
merged 2 commits into from
Nov 1, 2014
Merged

Multiple errors during name resolution #666

merged 2 commits into from
Nov 1, 2014

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented Nov 1, 2014

@garyb @joneshf Could you please review? Thanks.

@paf31
Copy link
Contributor Author

paf31 commented Nov 1, 2014

Resolves #524.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9eb1965 on 524 into 33db511 on master.

@garyb
Copy link
Member

garyb commented Nov 1, 2014

Oh, didn't realise it was this easy! 👍

@paf31
Copy link
Contributor Author

paf31 commented Nov 1, 2014

Yeah :) parU is supposed to just be a drop-in replacement for mapM but ideally, we would use an Applicative wrapper I guess.

Anyway, I'll have a stab at Names and then this should be done, yes?

@garyb
Copy link
Member

garyb commented Nov 1, 2014

Yep yep, sounds good 🍰

@paf31
Copy link
Contributor Author

paf31 commented Nov 1, 2014

Ok, I think this is good to go. How does it look?

@garyb
Copy link
Member

garyb commented Nov 1, 2014

Does TypeDeclarations need parU too?

@paf31
Copy link
Contributor Author

paf31 commented Nov 1, 2014

I left it out for now since desugarTypeDeclarations isn't written using mapM, although maybe it should be.

@garyb
Copy link
Member

garyb commented Nov 1, 2014

Ah ok, everything else looks good to me anyway. 👍

@paf31
Copy link
Contributor Author

paf31 commented Nov 1, 2014

Actually, this is exactly where using Applicative in a newtype would have been a better approach.

paf31 added a commit that referenced this pull request Nov 1, 2014
Multiple errors during name resolution
@paf31 paf31 merged commit af0492a into master Nov 1, 2014
@paf31 paf31 deleted the 524 branch November 1, 2014 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants