Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about using single quotes for --purs-args #637

Merged
merged 2 commits into from
May 8, 2020

Conversation

milesfrain
Copy link
Contributor

@milesfrain milesfrain commented May 8, 2020

It's confusing when porting commands from other tools which don't require quotes around purs args. For example:
This works:

psc-package build -- --codegen js,corefn

This does not:

spago build --purs-args --codegen js,corefn

This is required instead:

spago build --purs-args '--codegen js,corefn'

It's confusing when porting commands from other tools which don't require quotes around purs args. For example:
This works:
```
psc-package build -- --codegen js,corefn
```
This does not:
```
spago build --purs-args --codegen js,corefn
```
This is required instead:
```
spago build --purs-args '--codegen js,corefn'
```
@f-f
Copy link
Member

f-f commented May 8, 2020

Thank you for this! 🙂
Why not double quotes though? Single quotes do not work on Windows..

@milesfrain
Copy link
Contributor Author

Was basing it off of this example in the readme:

spago build --purs-args '-o myOutput/'

Ugg... so annoying you can't link to lines in a .md file.

I'll change this PR to just say "quotes"

Any style of quotes will do for Linux. Windows needs double quotes.
@f-f
Copy link
Member

f-f commented May 8, 2020

Oh, thanks for noting, maybe we should change that example too 😄

@f-f f-f added the mergify label May 8, 2020
@mergify mergify bot merged commit 2f23b67 into purescript:master May 8, 2020
@milesfrain milesfrain deleted the patch-1 branch June 16, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants