Proposal: Provide a Nix flake for Spago in Nix #963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
commented
May 29, 2023
| @@ -27,5 +27,6 @@ mkShell { | |||
| easy-ps.purescript-language-server | |||
| easy-ps.purs-tidy | |||
| nodejs | |||
| esbuild | |||
There was a problem hiding this comment.
I moved this to the shell instead of npm dependencies, since it's not really needed there.
thomashoneyman
commented
May 29, 2023
Comment on lines
+71
to
+75
| pkgs.writeShellScriptBin "spago-run" '' | ||
| echo "$@" | ||
| ${pkgs.nodejs}/bin/node --eval 'require("${packages.default}/bundle.js").main()' "$@" | ||
| '' | ||
| }/bin/spago-run"; |
There was a problem hiding this comment.
This doesn't work right now — perhaps you know how to pass through arguments, @f-f, or how to change the esbuild command?
|
An alternate implementation can be seen here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per a few discussions we've had lately in the #spago channel of the https://purescript.org/chat, this PR demonstrates building Spago in this repository via the
spago-nixproject. This avoids, for example, the many horrors of node2nix, napalm, npmlock2nix, buildNpmPackage, etc., and includes conveniences for the PureScript portion of building the Spago bundle.This PR demonstrates building Spago itself with Nix and exporting itself from a Nix flake so that users downstream can e.g. run:
and have access to Spago (or use it in their Nix builds). At the moment this is for demonstration purposes only — I don't intend this to be merged until we can discuss the implications.