lib: Move to go modules and shed a few tears #674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't seem to make this work. Locally if I do this: I get these scary errors. I've tried different things... Not sure how to fix this. It does build though. And the build errors here are different, but possible related?? @frebib I tried your branch as well and I get the same error locally... |
purpleidea
force-pushed
the
bug/go-mod
branch
2 times, most recently
from
8979522
to
63f11a8
Compare
frebib
reviewed
Sep 29, 2021
There was a problem hiding this comment.
@purpleidea I wonder if you have a stale cache or something. Pulling github.com/fsnotify/fsnotify in a blank new project works fine: https://gist.github.com/frebib/9944516ccbac6e55f593e6ed9a7d968b/raw
| return fmt.Errorf("program was not compiled correctly, see Makefile") | ||
| } | ||
| if cliArgs.Copying == "" { | ||
| return fmt.Errorf("program copyrights we're removed, can't run") |
| ) | ||
|
|
||
| // CLIArgs is a struct of values that we pass to the main CLI function. | ||
| type CLIArgs struct { |
There was a problem hiding this comment.
I noticed that we use Cli in gapi: https://github.com/purpleidea/mgmt/blob/master/gapi/gapi.go#L60
Should we change one or the other to be consistent?
purpleidea
force-pushed
the
bug/go-mod
branch
3 times, most recently
from
12c1b7a
to
d35037d
Compare
The old system with vendor/ and git submodules worked great, unfortunately FUD around git submodules seemed to scare people away and golang moved to a go.mod system that adds a new lock file format instead of using the built-in git version. It's now almost impossible to use modern golang without this, so we've switched. So much for the golang compatibility promise-- turns out it doesn't apply to the useful parts that I actually care about like this. Thanks to frebib for his incredibly valuable contributions to this patch. This snide commit message is mine alone. This patch also mixes in some changes due to legacy golang as we've also bumped the minimum version to 1.16 in the docs and tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old system with vendor/ and git submodules worked great,
unfortunately FUD around git submodules seemed to scare people away and
golang moved to a go.mod system that adds a new lock file format instead
of using the built-in git version. It's now almost impossible to use
modern golang without this, so we've switched.
So much for the golang compatibility promise-- turns out it doesn't
apply to the useful parts that I actually care about like this.
Thanks to frebib for his incredibly valuable contributions to this
patch. This snide commit message is mine alone.
This patch also mixes in some changes due to legacy golang as we've also
bumped the minimum version to 1.16 in the docs and tests.