Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in IE9 #1

Closed
mloughran opened this issue Feb 10, 2011 · 3 comments
Closed

Does not work in IE9 #1

mloughran opened this issue Feb 10, 2011 · 3 comments

Comments

@mloughran
Copy link
Contributor

Note: IE9 does not currently contain WebSockets.

When accessing http://pushertest.heroku.com/1.7.4-pre, pusher does not log anything

It may be that this is caused by the asynchronous dependency loading. To rule that out I tried http://pushertest.heroku.com/1.6.1 which loads all dependencies together. However there is an error with

if (window.console) window.console.log.apply(window.console, arguments);

"'arguments' is undefined"

Maybe there are two separate issues?

@mloughran
Copy link
Contributor Author

@ThisIsMissEm
Copy link
Contributor

What's the line numbers for this error? I think I may be able to spin up a windows machine tomorrow to test on IE9.

@mloughran
Copy link
Contributor Author

This is actually not a real issue.

pusher-js always worked fine with IE9, but I was testing with the developer tools open. The console.log function behaves differently in IE9 (http://stackoverflow.com/questions/5472938/does-ie9-support-console-log-and-is-it-a-real-function) which caused the Pusher.log function I had defined to break. Of course being IE the error was obtuse and it took random bisection to find the source of the problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants