Handle custom body content types #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
============================================
+ Coverage 62.2% 63.04% +0.84%
- Complexity 287 300 +13
============================================
Files 35 40 +5
Lines 918 966 +48
============================================
+ Hits 571 609 +38
- Misses 347 357 +10
|
Niktux
changed the title
| ]; | ||
| } | ||
|
|
||
| public function handleContentType($contentType, TypedBodyFactory $factory) |
There was a problem hiding this comment.
Missing in interface BodyFactory ?
There was a problem hiding this comment.
Nope
BodyFactory is a contract for an object which can build Body instance from amqp message payload.
This method is to allow to customize the behaviour of this very implementation of BodyFactory
| @@ -20,11 +21,12 @@ public function __construct(WorkerContext $workerContext) | |||
| { | |||
| $this->workerContext = $workerContext; | |||
| $this->eventDispatcher = new NullEventDispatcher(); | |||
| $this->messageAdapterFactory = null; | |||
There was a problem hiding this comment.
Used in L29 $message = $this->createMessageAdapter($message);
Explanation in https://github.com/puzzle-org/amqp/blob/2349818d10d230f30fe505fbb0219feeb0e075c6/src/Workers/MessageAdapterFactoryAware.php
It's a drawback of using traits :-(
| @@ -26,6 +29,8 @@ public function __construct(Application $console, Client $client, WorkerProvider | |||
| $this->client = $client; | |||
| $this->workerProvider = $workerProvider; | |||
| $this->outputInterfaceAware = $outputInterfaceAware; | |||
|
|
|||
| $this->messageAdapterFactory = null; | |||
There was a problem hiding this comment.
The messageAdapterFactory is mandatory, why using a setter instead of injecting it ?
Out of the box it is generating a fatal error
Catchable fatal error: Argument 1 passed to Puzzle\AMQP\Commands\Worker\Run::setMessageAdapterFactory() must be an instance of Puzzle\AMQP\Workers\MessageAdapterFactory, null given, called in /var/www/app/vendor/puzzle/amqp/src/Workers/WorkerCommands.php on line 46 and defined in /var/www/app/vendor/puzzle/amqp/src/Workers/MessageAdapterFactoryAware.php on line 10
The only thing that we can change in the MessageAdapterFactory is the BodyFactory.
The WorkerCommands could get the BodyFactory as a dependency, so it would be able to build the MessageAdapterFactory.
There was a problem hiding this comment.
The point is the missing nullable in type hinting (as we are support php 5, we have to use default value to manage it ... or sadly drop the type hinting)
You're right with the BodyFactory point but in conception view I wanted to preserve some layers of abstraction. That's why we have 2 levels of factories.
For the mandatory part, I've considered that users that don't need to customize theses parts must have nothing to do at all (so no BC break in API). That's why dependencies are optional and that's why there are fallbacks to set standards implementations if they don't provide any
…pterFactory was broken
|
fixed in 5ffc3c7 |
First commit : refactor
Second one : methods to inject custom mapping 'content_type => TypedBodyFactory implementation'
Refers to #34