Implement teams command refs: #55317 #11
Conversation
TheWalkingLeek
force-pushed
the
feature-55317-teams-command
branch
from
37cafab
to
76a8e50
Compare
TheWalkingLeek
changed the title
TheWalkingLeek
force-pushed
the
feature-55317-teams-command
branch
from
76a8e50
to
5b3a0cc
Compare
lib/cli.rb
Outdated
| require_relative 'adapters/ose_adapter' | ||
| require_relative 'models/account' | ||
| require_relative 'models/team' | ||
| require_relative 'models/ose_secret' |
There was a problem hiding this comment.
lib/serializers/team_serializer.rb
Outdated
| id: data[:id]) | ||
| end | ||
|
|
||
| def render_list(team) |
There was a problem hiding this comment.
doesn't #render_list belong to team model ?
There was a problem hiding this comment.
Hmm it does. But in the model, I simply delegate to this method. This way, you can easily call the method on your instance and the logic is inside the serializer. Do you think that's an unecessary delegation?
There was a problem hiding this comment.
Method definition on model is here: https://github.com/puzzle/ccli/pull/11/files#diff-ac0ed614502ed7cfc515046f59dc52e1R17
There was a problem hiding this comment.
I just think this has really nothing to do with the serializer, does it? the serializer is responsible for converting json to data and versa. whereas #render_list renders a list of folders.
In my opinion, this belongs more to the model in your case. Probably it would belong to a view layer. maybe introduce for example presenters and move it over there ?
There was a problem hiding this comment.
from wikipedia: The presenter acts upon the model and the view. It retrieves data from repositories (the model), and formats it for display in the view.
TheWalkingLeek
force-pushed
the
feature-55317-teams-command
branch
5 times, most recently
from
eeadb8e
to
122de50
Compare
TheWalkingLeek
force-pushed
the
feature-55317-teams-command
branch
from
122de50
to
5844a90
Compare
No description provided.