Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NPM packages #169

Merged
merged 2 commits into from
May 4, 2020
Merged

Upgrade NPM packages #169

merged 2 commits into from
May 4, 2020

Conversation

kfarnung
Copy link
Collaborator

@kfarnung kfarnung commented May 4, 2020

No description provided.

@beckbria
Copy link
Collaborator

beckbria commented May 4, 2020

The Travis error is:

TypeScript error in /home/travis/build/puzztool/puzztool/src/Common/KeyedCipherStream/index.tsx(81,13):
Type '(event: FormEvent) => void' is not assignable to type '(event: ChangeEvent) => void'.
Types of parameters 'event' and 'event' are incompatible.

If a minor version bump of a dependency broke this, that seems like a problem with that dependency. Is this a pre-existing failure?

@kfarnung
Copy link
Collaborator Author

kfarnung commented May 4, 2020

The Travis error is:

TypeScript error in /home/travis/build/puzztool/puzztool/src/Common/KeyedCipherStream/index.tsx(81,13):
Type '(event: FormEvent) => void' is not assignable to type '(event: ChangeEvent) => void'.
Types of parameters 'event' and 'event' are incompatible.

If a minor version bump of a dependency broke this, that seems like a problem with that dependency. Is this a pre-existing failure?

I suspect that they don't consider typing changes to be semver. Not ideal, but not a huge deal either.

react-bootstrap/react-bootstrap#5067

@beckbria
Copy link
Collaborator

beckbria commented May 4, 2020

Confirmed that this happens in a clean client, so this being out of date wasn't the source of the break. Thanks for fixing - I would argue that type changes should be semver, but then again I spend most of my life in statically-typed languages.

@beckbria beckbria self-assigned this May 4, 2020
@kfarnung
Copy link
Collaborator Author

kfarnung commented May 4, 2020

I agree with the sentiment, but I'm just glad to see more packages maintaining their own typings rather than relying on DefinitelyTyped.

@kfarnung kfarnung merged commit 56ca8d2 into master May 4, 2020
@kfarnung kfarnung deleted the npmupgrade branch May 4, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants