Support for all device cameras #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development
- Ability to switch to any cameraId by setting camera.facing - Api call to switch to the next camera id, looping through all cameras - Ability to retrieve a CameraMap with information about all the cameras (by facing direction) and CameraCharacteristics
|
Found a bug where switching camera modes can cause the camera to change because it is calling start() instead of start(cameraId). |
Development from head fork
# Conflicts: # cameraViewEx/src/main/api21/com/priyankvasa/android/cameraviewex/Camera2.kt # cameraViewEx/src/main/base/com/priyankvasa/android/cameraviewex/CameraInterface.kt
|
I have fixed the issue. So what was happening is if the user was on camera #2 and start() is called the chooseByFacing method would pick camera 0 or 1 and the camera would suddenly change. To fix this I call start(cameraId) from start and pass in camera.facing. I'm not sure the method I also merged the latest in from develop. |
Development merge from head fork
# Conflicts: # cameraViewEx/src/main/base/com/priyankvasa/android/cameraviewex/CameraInterface.kt # cameraViewEx/src/main/java/com/priyankvasa/android/cameraviewex/CameraView.kt
|
I have merged in the latest from development |
Merge fork develop in
# Conflicts: # cameraViewEx/src/main/api21/com/priyankvasa/android/cameraviewex/Camera2.kt
|
Updated this PR with the latest from the development branch. |
…Manager cameraCharacteristics
Implement preview frame listener for camera1
… Better exceptions.
Merge pvasa/development into development
# Conflicts: # cameraViewEx/src/main/api14/com/priyankvasa/android/cameraviewex/Camera1.kt # cameraViewEx/src/main/api21/com/priyankvasa/android/cameraviewex/Camera2.kt
pvasa
force-pushed
the
development
branch
2 times, most recently
from
7280f31
to
f2e7cd9
Compare
pvasa
force-pushed
the
development
branch
3 times, most recently
from
3aeec10
to
a396a9f
Compare
|
@pcm2a I am closing this PR to recreate |
pvasa
added
enhancement
pvasa
force-pushed
the
development
branch
3 times, most recently
from
127f0ae
to
0ab1fb7
Compare
pvasa
force-pushed
the
development
branch
2 times, most recently
from
5235e1e
to
c071065
Compare
pvasa
force-pushed
the
development
branch
4 times, most recently
from
52286f5
to
5c7fd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few features that I wasn't sure if it made sense to split up. I also included some examples in the sampleApp CameraFragment. I can remove them if needed.
start(cameraId: Int)camera.nextCamera()camera.facing = 2would switch to camera 2-- Retrieve camera ids by facing direction (all front or back cameras)
-- Retrieve CameraCharacteristics by camera id
-- Retrieve the direction a camera is facing by camera id
If a device has two back cameras the device's camera will have one toggle to change from front to back. When on the back camera there will be additional icons to switch between each back camera. An example would be an icon of a "regular" view and a "wide angle" view or a "zoom" view. The camera map will provide enough information to display all of this in the UI. Another example is the LG V40 that has three back cameras, with icons for wide angle, regular and zoom.