Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_psm3, 0.9.0 whats new doc fixes #1169

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Feb 15, 2021

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@wholmgren wholmgren added this to the 0.9.0 milestone Feb 15, 2021
@wholmgren
Copy link
Member Author

@kanderso-nrel The "Data File Format" section of https://developer.nrel.gov/docs/solar/nsrdb/psm3-tmy-download/ contains a broken link to a PDF documentation of the format. This PR brought to you by my surprise that the TMY data from the NSRDB API (or at least pvlib's get_psm3 function) returns data on the half hour instead of the hour (like the old files).

@kandersolar
Copy link
Member

@kanderso-nrel The "Data File Format" section of https://developer.nrel.gov/docs/solar/nsrdb/psm3-tmy-download/ contains a broken link to a PDF documentation of the format.

Thanks. If you're still after that PDF in the meantime, there's a copy of it on the wayback machine -- see link here: NREL/developer.nrel.gov#196

@wholmgren wholmgren merged commit 8b98768 into pvlib:master Feb 16, 2021
@wholmgren wholmgren deleted the psm3docfix branch February 16, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants