Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize v0.9.0 #1301

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Finalize v0.9.0 #1301

merged 3 commits into from
Sep 1, 2021

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Sep 1, 2021

  • Closes pvlib v0.9 release planning #1214
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the 0.9.0 milestone Sep 1, 2021
@kandersolar
Copy link
Member Author

Test failures are a 404 in the read_epw_remote test. Seems like the same thing as this: NREL/EnergyPlus#9036, see my comment in that thread. Might want to xfail that test depending on what they say.

Sphinx output looks fine to me. There is some log noise about deprecated functions but I don't think there's any action needed there.

@kandersolar kandersolar marked this pull request as ready for review September 1, 2021 20:49
@kandersolar
Copy link
Member Author

@mikofski see my comment above :)

@mikofski
Copy link
Member

mikofski commented Sep 1, 2021

new links are:
https://energyplus-weather.s3.amazonaws.com/europe_wmo_region_6/NLD/NLD_Amsterdam.062400_IWEC/NLD_Amsterdam.062400_IWEC.epw

they moved from ghpages to AWS s3:
https://energyplus-weather.s3.amazonaws.com/europe_wmo_region_6/NLD/NLD_Amsterdam.062400_IWEC/NLD_Amsterdam.062400_IWEC.epw

@kandersolar
Copy link
Member Author

Ok @mikofski's url works, someone else merge this if they're good with that change

@wholmgren wholmgren merged commit 518cc35 into pvlib:master Sep 1, 2021
@wholmgren
Copy link
Member

Kevin do you want to tag too?

@kandersolar kandersolar deleted the v090 branch September 1, 2021 22:44
@mikofski
Copy link
Member

mikofski commented Sep 1, 2021

Shall I send out announcements? Unfortunately too late for NF August newsletter, but I'll let them know for September. Let me know if there's anything from the release notes that you want me to highlight.

@mikofski
Copy link
Member

mikofski commented Sep 1, 2021

I'll do announcements a little later today. Thanks Kevin, Will, Cliff, Adam, Anton, and everyone who contributed new and previously :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pvlib v0.9 release planning
4 participants