-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize 0.9.2 #1534
Finalize 0.9.2 #1534
Conversation
The forecasting User Guide page is broken from the same issue all those users were hitting (see PR, latest). Unidata/tds#269 makes it sound like it might not ever start working again unless we change |
I'd do nothing. I doubt anyone will read it anyways. |
Ok, in that case I think this is ready for review. |
@@ -79,3 +76,6 @@ Contributors | |||
* Jules Chéron (:ghuser:`jules-ch`) | |||
* Kurt Rhee (:ghuser:`kurt-rhee`) | |||
* Will Hobbs (:ghuser:`williamhobbs`) | |||
* Stephen Schneider (:ghuser:`sjschneider`) | |||
* :ghuser:`Kaesekopf` | |||
* :ghuser:`hf-kklein` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to acknowledge people that have contributed to discussions in issues/PRs. Does this list include a quick read for those people? If not I can help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sloppy of me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if GitHub could make that automatic. As it is, I think the best thing we can do is to add more co-authors to commits. See Hynek's TIL for how to do that easily. Then use a tool for automating the contributor list.
@kanderso-nrel you seem to be on top of the housekeeping today, so I suggest you make the tag if you think we're ready. |
Yep, on it |
[ ] Tests added[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data
) and Milestone are assigned to the Pull Request and linked Issue.