Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize 0.9.2 #1534

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Finalize 0.9.2 #1534

merged 3 commits into from
Aug 19, 2022

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Aug 19, 2022

  • Closes v0.9.2 release plan #1506
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the 0.9.2 milestone Aug 19, 2022
@kandersolar
Copy link
Member Author

The forecasting User Guide page is broken from the same issue all those users were hitting (see PR, latest). Unidata/tds#269 makes it sound like it might not ever start working again unless we change forecast.py. I don't see much value in documenting code that doesn't work, and I doubt any of us is willing to get the code working again. We could nix the forecasting page, or add some new text to the warning at the top, or just do nothing. Thoughts?

@wholmgren
Copy link
Member

We could nix the forecasting page, or add some new text to the warning at the top, or just do nothing. Thoughts?

I'd do nothing. I doubt anyone will read it anyways.

@kandersolar kandersolar marked this pull request as ready for review August 19, 2022 19:12
@kandersolar
Copy link
Member Author

Ok, in that case I think this is ready for review.

@@ -79,3 +76,6 @@ Contributors
* Jules Chéron (:ghuser:`jules-ch`)
* Kurt Rhee (:ghuser:`kurt-rhee`)
* Will Hobbs (:ghuser:`williamhobbs`)
* Stephen Schneider (:ghuser:`sjschneider`)
* :ghuser:`Kaesekopf`
* :ghuser:`hf-kklein`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to acknowledge people that have contributed to discussions in issues/PRs. Does this list include a quick read for those people? If not I can help.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sloppy of me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if GitHub could make that automatic. As it is, I think the best thing we can do is to add more co-authors to commits. See Hynek's TIL for how to do that easily. Then use a tool for automating the contributor list.

@wholmgren wholmgren merged commit 6ffe257 into pvlib:master Aug 19, 2022
@wholmgren
Copy link
Member

@kanderso-nrel you seem to be on top of the housekeeping today, so I suggest you make the tag if you think we're ready.

@kandersolar
Copy link
Member Author

Yep, on it

@kandersolar kandersolar deleted the 092-release branch August 19, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.9.2 release plan
2 participants