-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pvlib.forecast
#1766
Remove pvlib.forecast
#1766
Conversation
Note that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a light review and things seem to check out.
Hearing no objections, away it goes! |
The end of an era! Thanks for cleaning up my mess! |
Hey, I am Stefan, a Student from Germany. Might I ask why you removed the feature ? I was going to use it for my masters thesis. |
Hello @stefan-hoermann, see #1057 and #1426 for discussion about this decision. I'm not sure if it will be helpful, but you might try searching the pvlib google group to see what other people are using instead of |
@stefan-hoermann Note, you can always install previous versions of pvlib, which has the forecasting module, although not all of the functionality still works. |
Thank you for your quick answers. Looking through the discussions with all of the bugs I might need an alternative. I am looking for a radiation prognosis tool, maybe the "Solar Forecast Arbiter" mentioned in #1057 is an alternative. Although I hope there may be a solution which directly accesses the database of institutions like e.g. the "Deutscher Wetter Dienst". At least I think thats how pvlib worked, or not? |
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Following the thumbs up on #1735 (comment), this PR removes
pvlib.forecast
. Removingpvlib.forecast
, combined with #1654, means that several optional dependencies (siphon, netcdf4, cftime) are no longer used anywhere and can also be removed. This PR removes them here, but we should also remember to remove them from our conda-forge feedstock when we release v0.10.0.