Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pvlib.forecast #1766

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Remove pvlib.forecast #1766

merged 7 commits into from
Jun 23, 2023

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jun 8, 2023

Following the thumbs up on #1735 (comment), this PR removes pvlib.forecast. Removing pvlib.forecast, combined with #1654, means that several optional dependencies (siphon, netcdf4, cftime) are no longer used anywhere and can also be removed. This PR removes them here, but we should also remember to remove them from our conda-forge feedstock when we release v0.10.0.

@kandersolar kandersolar added the api label Jun 8, 2023
@kandersolar kandersolar added this to the 0.10.0 milestone Jun 8, 2023
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Jun 8, 2023
@kandersolar kandersolar mentioned this pull request Jun 8, 2023
@kandersolar
Copy link
Member Author

Note that the remote-data tests are expected to fail here due to the fact that the modified workflow is not run on the PR containing the modification. See here for the longer explanation.

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a light review and things seem to check out.

@kandersolar kandersolar added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jun 20, 2023
@kandersolar
Copy link
Member Author

Hearing no objections, away it goes!

@kandersolar kandersolar merged commit 9d8ca55 into pvlib:main Jun 23, 2023
@kandersolar kandersolar deleted the forecast branch June 23, 2023 17:19
@wholmgren
Copy link
Member

The end of an era! Thanks for cleaning up my mess!

@kandersolar kandersolar mentioned this pull request Jun 29, 2023
3 tasks
@stefan-hoermann
Copy link

Hey, I am Stefan, a Student from Germany. Might I ask why you removed the feature ? I was going to use it for my masters thesis.

@kandersolar
Copy link
Member Author

Hello @stefan-hoermann, see #1057 and #1426 for discussion about this decision.

I'm not sure if it will be helpful, but you might try searching the pvlib google group to see what other people are using instead of pvlib.forecast.

@AdamRJensen
Copy link
Member

@stefan-hoermann Note, you can always install previous versions of pvlib, which has the forecasting module, although not all of the functionality still works.

@stefan-hoermann
Copy link

Thank you for your quick answers. Looking through the discussions with all of the bugs I might need an alternative. I am looking for a radiation prognosis tool, maybe the "Solar Forecast Arbiter" mentioned in #1057 is an alternative. Although I hope there may be a solution which directly accesses the database of institutions like e.g. the "Deutscher Wetter Dienst". At least I think thats how pvlib worked, or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api remote-data triggers --remote-data pytests
Projects
None yet
4 participants