update incorrect statements in ModelChain documentation #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because the NREL TMY server is rejecting a request for data. I will open an issue if it continues. |
cwhanse
reviewed
Jun 23, 2018
pvlib/modelchain.py
Outdated
|
|
||
| CEC module specifications and the single diode model are not yet | ||
| supported. | ||
| A class to provide a high-level interface for standarized |
There was a problem hiding this comment.
I think we should keep the 'all of the modeling steps' language here
markcampanelli
approved these changes
Jun 24, 2018
There was a problem hiding this comment.
I don't think this closes #475, as stated above. I appreciate these corrections.
|
Ah I linked to the wrong issue! This closes #480. @thunderfish24 I don't follow the meaning behind "as stated above." Did a comment get dropped? |
|
@wholmgren All is well. I was just trying to refer to the text I was talking about in the PR template. |
|
thanks for the reviews @cwhanse and @thunderfish24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffand/or landscape.io linting service.docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.These simple fixes are ready to go as far as I'm concerned, but happy to make edits if requested.