Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show exit code #122

Merged
merged 1 commit into from
Mar 15, 2024
Merged

feat: show exit code #122

merged 1 commit into from
Mar 15, 2024

Conversation

ankush
Copy link
Contributor

@ankush ankush commented Mar 14, 2024

image

Implementation:

  • Proc handle keeps track of exit code
  • Stopped event now passes exit code too, ProcHandle stores this.
  • in UI we show exit code if the process actually started and exited, else previous behaviour.

alternative to #118
closes #116

P.S. - I know Rust about as much as that bot, so feel free to close the PR if it doesn't meet the expectation 😄

I love mprocs btw, thanks for this amazing tool!

Edit: Merged, my job is safe from LLMs!

image

@ankush ankush marked this pull request as ready for review March 14, 2024 16:23
@pvolok
Copy link
Owner

pvolok commented Mar 15, 2024

Thank you!

@pvolok pvolok merged commit 2461e7a into pvolok:master Mar 15, 2024
@ankush ankush deleted the show_exit_code branch March 15, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convey exit status for stopped processes
2 participants