-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS]: Luminosity Contrast Ratio is 2.646.1 for the Placeholder text of the Search edit field. #4750
Comments
This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue . |
5 similar comments
This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue . |
This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue . |
This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue . |
This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue . |
This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue . |
fixes #4750 fixes #4749 fixes #4754 ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> Other... Please describe: Accessibility fixes Also added typescript as a dependency to fix a build issue with npm start + updated shoelace to the latest version ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
Closed with the above PR |
What happened?
The color contrast ratio is 2.646.1 for the Placeholder text of the Search edit field which is very less than expected ratio.
How do we reproduce the behavior?
Repro Steps:
What do you expect to happen?
The color contrast ratio for the Placeholder text of the Search edit field should be greater than or equal to 4.5:1.
What environment were you using?
Test Environment:
OS Build: Windows 11 Enterprise Insider Preview 24H2 (26120.961)
Edge Browser: Version 127.0.2651.2 (Official build) dev (64-bit)
User ID: V-
Tool: Color Contrast Analyser
URL: https://docs.pwabuilder.com/#/home/native-features
Additional context
User Experience:
When a minimum contrast ratio is not provided between text and its background, it is difficult for low-vision users as well as anyone in extreme lighting environments to read the content.
WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html
Attachment:
The text was updated successfully, but these errors were encountered: