Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routes to support Settings-Environment Variables #19

Merged
merged 2 commits into from
Nov 22, 2017

Conversation

lyalamanchili
Copy link
Contributor

These endpoints are to support setting environment variables - https://docs.travis-ci.com/api#settings:-environment-variables

@pwmckenna Can you please merge the pull request?

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@ljharb
Copy link
Collaborator

ljharb commented Nov 15, 2017

@lyalamanchili altho tests are failing.

@pwmckenna
Copy link
Owner

lgtm. @ljharb you can merge/publish correct?

@ljharb
Copy link
Collaborator

ljharb commented Nov 22, 2017

Yup, I can! I'm going to let it sit in master for a bit before releasing, tho, and I'm hesitant to release before travis-ci can be fixed.

@ljharb ljharb merged commit 5553d98 into pwmckenna:master Nov 22, 2017
@travi
Copy link

travi commented Aug 15, 2018

i'm very confused by this addition but its quite likely that i'm missing something somewhat obvious.

when i attempt to even try getting env vars, with

travis.settings.env_vars.get((err, res) => {
    if (err) console.log(err)
    else console.log(res)
  })

i get the following error: Error: Couldn't find repository

from the docs, it looks like the repository_id needs to be provided as a query parameter, but i haven't figured out how to provide query parameters. am i overlooking how to supply query parameters?

@travi travi mentioned this pull request Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants