Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting gdblib.regs.<reg>=<val> #1267

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

disconnect3d
Copy link
Member

This commit allows for setting the selected thread's registers by using the pwndbg.gdblib.regs. = expressions. Before this commit invoking such Python code would set the internal Pwndbg register value, but not really the inferior value. This could lead to weird issues when the displayed context shows the new register value but e.g. info reg rax displays the old value.

This commit allows for setting the selected thread's registers by using
the pwndbg.gdblib.regs.<register-name> = <new-value> expressions. Before
this commit invoking such Python code would set the internal Pwndbg
register value, but not really the inferior value. This could lead to
weird issues when the displayed context shows the new register value but
e.g. `info reg rax` displays the old value.
@codecov-commenter
Copy link

Codecov Report

Merging #1267 (91e5336) into dev (bfbb2b8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1267      +/-   ##
==========================================
- Coverage   54.45%   54.45%   -0.01%     
==========================================
  Files         182      182              
  Lines       20214    20213       -1     
  Branches     1865     1866       +1     
==========================================
- Hits        11008    11007       -1     
  Misses       8783     8783              
  Partials      423      423              
Impacted Files Coverage Δ
pwndbg/commands/mprotect.py 100.00% <ø> (ø)
pwndbg/gdblib/regs.py 67.10% <100.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@disconnect3d disconnect3d merged commit d424442 into dev Oct 11, 2022
@disconnect3d disconnect3d deleted the allow-setting-gdblib-regs branch October 11, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants